LU-1445 lod: clean up lod_fld_lookup() return codes

[fs/lustre-release.git] / lustre / lod / lod_qos.c

diff --git a/lustre/lod/lod_qos.c b/lustre/lod/lod_qos.c
index 065ade0..6be2281 100644 (file)
--- a/lustre/lod/lod_qos.c
+++ b/lustre/lod/lod_qos.c
@@ -50,13 +50,8 @@
 
 #define D_QOS   D_OTHER
 
-#if 0
-#define QOS_DEBUG(fmt, ...)     CDEBUG(D_OTHER, fmt, ## __VA_ARGS__)
-#define QOS_CONSOLE(fmt, ...)   LCONSOLE(D_OTHER, fmt, ## __VA_ARGS__)
-#else
-#define QOS_DEBUG(fmt, ...)
-#define QOS_CONSOLE(fmt, ...)
-#endif
+#define QOS_DEBUG(fmt, ...)     CDEBUG(D_QOS, fmt, ## __VA_ARGS__)
+#define QOS_CONSOLE(fmt, ...)   LCONSOLE(D_QOS, fmt, ## __VA_ARGS__)
 
 #define TGT_BAVAIL(i) (OST_TGT(lod,i)->ltd_statfs.os_bavail * \
                       OST_TGT(lod,i)->ltd_statfs.os_bsize)
@@ -195,6 +190,7 @@ static int lod_statfs_and_check(const struct lu_env *env, struct lod_device *d,
 {
        struct lod_tgt_desc *ost;
        int                  rc;
+       ENTRY;
 
        LASSERT(d);
        ost = OST_TGT(d,index);
@@ -258,7 +254,7 @@ static void lod_qos_statfs_update(const struct lu_env *env,
        struct obd_device *obd = lod2obd(lod);
        struct ost_pool   *osts = &(lod->lod_pool_info);
        unsigned int       i;
-       int                idx, rc = 0;
+       int                idx;
        __u64              max_age, avail;
        ENTRY;
 
@@ -270,15 +266,14 @@ static void lod_qos_statfs_update(const struct lu_env *env,
 
        down_write(&lod->lod_qos.lq_rw_sem);
        if (cfs_time_beforeq_64(max_age, obd->obd_osfs_age))
-               GOTO(out, rc = 0);
+               goto out;
 
        for (i = 0; i < osts->op_count; i++) {
                idx = osts->op_array[i];
                avail = OST_TGT(lod,idx)->ltd_statfs.os_bavail;
-               rc = lod_statfs_and_check(env, lod, idx,
-                                         &OST_TGT(lod,idx)->ltd_statfs);
-               if (rc)
-                       break;
+               if (lod_statfs_and_check(env, lod, idx,
+                                        &OST_TGT(lod, idx)->ltd_statfs))
+                       continue;
                if (OST_TGT(lod,idx)->ltd_statfs.os_bavail != avail)
                        /* recalculate weigths */
                        lod->lod_qos.lq_dirty = 1;