/**
* This is _inode_ placement policy function (not name).
*/
-static int lmv_placement_policy(struct obd_device *obd,
- struct md_op_data *op_data, u32 *mds)
+static u32 lmv_placement_policy(struct obd_device *obd,
+ struct md_op_data *op_data)
{
- struct lmv_obd *lmv = &obd->u.lmv;
+ struct lmv_obd *lmv = &obd->u.lmv;
struct lmv_user_md *lum;
+ u32 mdt;
ENTRY;
- LASSERT(mds != NULL);
-
- if (lmv->desc.ld_tgt_count == 1) {
- *mds = 0;
+ if (lmv->desc.ld_tgt_count == 1)
RETURN(0);
- }
lum = op_data->op_data;
- /* Choose MDS by
+ /*
+ * Choose MDT by
* 1. See if the stripe offset is specified by lum.
- * 2. Then check if there is default stripe offset.
- * 3. Finally choose MDS by name hash if the parent
+ * 2. If parent has default LMV, and its hash type is "space", choose
+ * MDT with QoS. (see lmv_locate_tgt_qos()).
+ * 3. Then check if default LMV stripe offset is not -1.
+ * 4. Finally choose MDS by name hash if the parent
* is striped directory. (see lmv_locate_tgt()).
*
* presently explicit MDT location is not supported
if (op_data->op_cli_flags & CLI_SET_MEA && lum != NULL &&
le32_to_cpu(lum->lum_magic != LMV_MAGIC_FOREIGN) &&
le32_to_cpu(lum->lum_stripe_offset) != (__u32)-1) {
- *mds = le32_to_cpu(lum->lum_stripe_offset);
+ mdt = le32_to_cpu(lum->lum_stripe_offset);
+ } else if (op_data->op_code == LUSTRE_OPC_MKDIR &&
+ !lmv_dir_striped(op_data->op_mea1) &&
+ lmv_dir_space_hashed(op_data->op_default_mea1)) {
+ mdt = op_data->op_mds;
} else if (op_data->op_code == LUSTRE_OPC_MKDIR &&
op_data->op_default_mea1 &&
op_data->op_default_mea1->lsm_md_master_mdt_index !=
- (__u32)-1) {
- *mds = op_data->op_default_mea1->lsm_md_master_mdt_index;
- op_data->op_mds = *mds;
+ (__u32)-1) {
+ mdt = op_data->op_default_mea1->lsm_md_master_mdt_index;
+ op_data->op_mds = mdt;
} else {
- *mds = op_data->op_mds;
+ mdt = op_data->op_mds;
}
- RETURN(0);
+ RETURN(mdt);
}
int __lmv_fid_alloc(struct lmv_obd *lmv, struct lu_fid *fid, u32 mds)
rc = 0;
}
- EXIT;
+ EXIT;
out:
mutex_unlock(&tgt->ltd_fid_mutex);
- return rc;
+ return rc;
}
int lmv_fid_alloc(const struct lu_env *env, struct obd_export *exp,
struct lu_fid *fid, struct md_op_data *op_data)
{
- struct obd_device *obd = class_exp2obd(exp);
- struct lmv_obd *lmv = &obd->u.lmv;
- u32 mds = 0;
- int rc;
- ENTRY;
+ struct obd_device *obd = class_exp2obd(exp);
+ struct lmv_obd *lmv = &obd->u.lmv;
+ u32 mds;
+ int rc;
- LASSERT(op_data != NULL);
- LASSERT(fid != NULL);
+ ENTRY;
- rc = lmv_placement_policy(obd, op_data, &mds);
- if (rc) {
- CERROR("Can't get target for allocating fid, "
- "rc %d\n", rc);
- RETURN(rc);
- }
+ LASSERT(op_data != NULL);
+ LASSERT(fid != NULL);
- rc = __lmv_fid_alloc(lmv, fid, mds);
- if (rc) {
- CERROR("Can't alloc new fid, rc %d\n", rc);
- RETURN(rc);
- }
+ mds = lmv_placement_policy(obd, op_data);
- RETURN(rc);
+ rc = __lmv_fid_alloc(lmv, fid, mds);
+ if (rc)
+ CERROR("Can't alloc new fid, rc %d\n", rc);
+
+ RETURN(rc);
}
static int lmv_setup(struct obd_device *obd, struct lustre_cfg *lcfg)
RETURN(rc);
}
-struct lmv_tgt_desc*
-__lmv_locate_tgt(struct lmv_obd *lmv, struct lmv_stripe_md *lsm,
- const char *name, int namelen, struct lu_fid *fid, u32 *mds,
- bool post_migrate)
+static struct lmv_tgt_desc *lmv_locate_tgt_qos(struct lmv_obd *lmv, __u32 *mdt)
+{
+ static unsigned int rr_index;
+
+ /* locate MDT round-robin is the first step */
+ *mdt = rr_index % lmv->tgts_size;
+ rr_index++;
+
+ return lmv->tgts[*mdt];
+}
+
+static struct lmv_tgt_desc *
+lmv_locate_tgt_by_name(struct lmv_obd *lmv, struct lmv_stripe_md *lsm,
+ const char *name, int namelen, struct lu_fid *fid,
+ __u32 *mds, bool post_migrate)
{
struct lmv_tgt_desc *tgt;
const struct lmv_oinfo *oinfo;
- if (lsm == NULL || namelen == 0) {
+ if (!lmv_dir_striped(lsm) || !namelen) {
tgt = lmv_find_target(lmv, fid);
if (IS_ERR(tgt))
return tgt;
- LASSERT(mds);
*mds = tgt->ltd_idx;
return tgt;
}
return ERR_CAST(oinfo);
}
- if (fid != NULL)
- *fid = oinfo->lmo_fid;
- if (mds != NULL)
- *mds = oinfo->lmo_mds;
-
+ *fid = oinfo->lmo_fid;
+ *mds = oinfo->lmo_mds;
tgt = lmv_get_target(lmv, oinfo->lmo_mds, NULL);
- CDEBUG(D_INFO, "locate on mds %u "DFID"\n", oinfo->lmo_mds,
- PFID(&oinfo->lmo_fid));
+ CDEBUG(D_INODE, "locate MDT %u parent "DFID"\n", *mds, PFID(fid));
return tgt;
}
-
/**
- * Locate mdt by fid or name
+ * Locate MDT of op_data->op_fid1
*
* For striped directory, it will locate the stripe by name hash, if hash_type
* is unknown, it will return the stripe specified by 'op_data->op_stripe_index'
* which is set outside, and if dir is migrating, 'op_data->op_post_migrate'
* indicates whether old or new layout is used to locate.
*
- * For normal direcotry, it will locate MDS by FID directly.
+ * For plain direcotry, normally it will locate MDT by FID, but if this
+ * directory has default LMV, and its hash type is "space", locate MDT with QoS.
*
* \param[in] lmv LMV device
* \param[in] op_data client MD stack parameters, name, namelen
* mds_num etc.
- * \param[in] fid object FID used to locate MDS.
*
* retval pointer to the lmv_tgt_desc if succeed.
* ERR_PTR(errno) if failed.
*/
-struct lmv_tgt_desc*
-lmv_locate_tgt(struct lmv_obd *lmv, struct md_op_data *op_data,
- struct lu_fid *fid)
+struct lmv_tgt_desc *
+lmv_locate_tgt(struct lmv_obd *lmv, struct md_op_data *op_data)
{
struct lmv_stripe_md *lsm = op_data->op_mea1;
struct lmv_oinfo *oinfo;
struct lmv_tgt_desc *tgt;
- /* foreign dir is not striped dir */
- if (lsm && lsm->lsm_md_magic == LMV_MAGIC_FOREIGN)
+ if (lmv_dir_foreign(lsm))
return ERR_PTR(-ENODATA);
/* During creating VOLATILE file, it should honor the mdt
if (IS_ERR(tgt))
return tgt;
- if (lsm) {
+ if (lmv_dir_striped(lsm)) {
int i;
/* refill the right parent fid */
for (i = 0; i < lsm->lsm_md_stripe_count; i++) {
oinfo = &lsm->lsm_md_oinfo[i];
if (oinfo->lmo_mds == op_data->op_mds) {
- *fid = oinfo->lmo_fid;
+ op_data->op_fid1 = oinfo->lmo_fid;
break;
}
}
if (i == lsm->lsm_md_stripe_count)
- *fid = lsm->lsm_md_oinfo[0].lmo_fid;
+ op_data->op_fid1 = lsm->lsm_md_oinfo[0].lmo_fid;
}
- } else if (lmv_is_dir_bad_hash(lsm)) {
+ } else if (lmv_dir_bad_hash(lsm)) {
LASSERT(op_data->op_stripe_index < lsm->lsm_md_stripe_count);
oinfo = &lsm->lsm_md_oinfo[op_data->op_stripe_index];
- *fid = oinfo->lmo_fid;
+ op_data->op_fid1 = oinfo->lmo_fid;
op_data->op_mds = oinfo->lmo_mds;
tgt = lmv_get_target(lmv, oinfo->lmo_mds, NULL);
+ } else if (op_data->op_code == LUSTRE_OPC_MKDIR &&
+ lmv_dir_space_hashed(op_data->op_default_mea1) &&
+ !lmv_dir_striped(lsm)) {
+ tgt = lmv_locate_tgt_qos(lmv, &op_data->op_mds);
+ /*
+ * only update statfs when mkdir under dir with "space" hash,
+ * this means the cached statfs may be stale, and current mkdir
+ * may not follow QoS accurately, but it's not serious, and it
+ * avoids periodic statfs when client doesn't mkdir under
+ * "space" hashed directories.
+ */
+ if (!IS_ERR(tgt)) {
+ struct obd_device *obd;
+
+ obd = container_of(lmv, struct obd_device, u.lmv);
+ lmv_statfs_check_update(obd, tgt);
+ }
} else {
- tgt = __lmv_locate_tgt(lmv, lsm, op_data->op_name,
- op_data->op_namelen, fid,
- &op_data->op_mds,
- op_data->op_post_migrate);
+ tgt = lmv_locate_tgt_by_name(lmv, op_data->op_mea1,
+ op_data->op_name, op_data->op_namelen,
+ &op_data->op_fid1, &op_data->op_mds,
+ op_data->op_post_migrate);
}
return tgt;
}
+/* Locate MDT of op_data->op_fid2 for link/rename */
+static struct lmv_tgt_desc *
+lmv_locate_tgt2(struct lmv_obd *lmv, struct md_op_data *op_data)
+{
+ struct lmv_tgt_desc *tgt;
+ int rc;
+
+ LASSERT(op_data->op_name);
+ if (lmv_dir_migrating(op_data->op_mea2)) {
+ struct lu_fid fid1 = op_data->op_fid1;
+ struct lmv_stripe_md *lsm1 = op_data->op_mea1;
+ struct ptlrpc_request *request = NULL;
+
+ /*
+ * avoid creating new file under old layout of migrating
+ * directory, check it here.
+ */
+ tgt = lmv_locate_tgt_by_name(lmv, op_data->op_mea2,
+ op_data->op_name, op_data->op_namelen,
+ &op_data->op_fid2, &op_data->op_mds, false);
+ if (IS_ERR(tgt))
+ RETURN(tgt);
+
+ op_data->op_fid1 = op_data->op_fid2;
+ op_data->op_mea1 = op_data->op_mea2;
+ rc = md_getattr_name(tgt->ltd_exp, op_data, &request);
+ op_data->op_fid1 = fid1;
+ op_data->op_mea1 = lsm1;
+ if (!rc) {
+ ptlrpc_req_finished(request);
+ RETURN(ERR_PTR(-EEXIST));
+ }
+
+ if (rc != -ENOENT)
+ RETURN(ERR_PTR(rc));
+ }
+
+ return lmv_locate_tgt_by_name(lmv, op_data->op_mea2, op_data->op_name,
+ op_data->op_namelen, &op_data->op_fid2,
+ &op_data->op_mds, true);
+}
+
int lmv_create(struct obd_export *exp, struct md_op_data *op_data,
const void *data, size_t datalen, umode_t mode, uid_t uid,
gid_t gid, cfs_cap_t cap_effective, __u64 rdev,
struct ptlrpc_request **request)
{
- struct obd_device *obd = exp->exp_obd;
- struct lmv_obd *lmv = &obd->u.lmv;
- struct lmv_tgt_desc *tgt;
- int rc;
+ struct obd_device *obd = exp->exp_obd;
+ struct lmv_obd *lmv = &obd->u.lmv;
+ struct lmv_tgt_desc *tgt;
+ int rc;
+
ENTRY;
if (!lmv->desc.ld_active_tgt_count)
RETURN(-EIO);
- if (lmv_is_dir_bad_hash(op_data->op_mea1))
+ if (lmv_dir_bad_hash(op_data->op_mea1))
RETURN(-EBADF);
- if (lmv_is_dir_migrating(op_data->op_mea1)) {
+ if (lmv_dir_migrating(op_data->op_mea1)) {
/*
* if parent is migrating, create() needs to lookup existing
* name, to avoid creating new file under old layout of
* migrating directory, check old layout here.
*/
- tgt = lmv_locate_tgt(lmv, op_data, &op_data->op_fid1);
+ tgt = lmv_locate_tgt(lmv, op_data);
if (IS_ERR(tgt))
RETURN(PTR_ERR(tgt));
op_data->op_post_migrate = true;
}
- tgt = lmv_locate_tgt(lmv, op_data, &op_data->op_fid1);
+ tgt = lmv_locate_tgt(lmv, op_data);
if (IS_ERR(tgt))
RETURN(PTR_ERR(tgt));
RETURN(PTR_ERR(tgt));
op_data->op_mds = tgt->ltd_idx;
- } else {
- CDEBUG(D_CONFIG, "Server doesn't support striped dirs\n");
}
CDEBUG(D_INODE, "CREATE obj "DFID" -> mds #%x\n",
ENTRY;
retry:
- tgt = lmv_locate_tgt(lmv, op_data, &op_data->op_fid1);
+ tgt = lmv_locate_tgt(lmv, op_data);
if (IS_ERR(tgt))
RETURN(PTR_ERR(tgt));
op_data->op_fsgid = from_kgid(&init_user_ns, current_fsgid());
op_data->op_cap = cfs_curproc_cap_pack();
- if (lmv_is_dir_migrating(op_data->op_mea2)) {
- struct lu_fid fid1 = op_data->op_fid1;
- struct lmv_stripe_md *lsm1 = op_data->op_mea1;
-
- /*
- * avoid creating new file under old layout of migrating
- * directory, check it here.
- */
- tgt = __lmv_locate_tgt(lmv, op_data->op_mea2, op_data->op_name,
- op_data->op_namelen, &op_data->op_fid2,
- &op_data->op_mds, false);
- tgt = lmv_locate_tgt(lmv, op_data, &op_data->op_fid1);
- if (IS_ERR(tgt))
- RETURN(PTR_ERR(tgt));
-
- op_data->op_fid1 = op_data->op_fid2;
- op_data->op_mea1 = op_data->op_mea2;
- rc = md_getattr_name(tgt->ltd_exp, op_data, request);
- op_data->op_fid1 = fid1;
- op_data->op_mea1 = lsm1;
- if (!rc) {
- ptlrpc_req_finished(*request);
- *request = NULL;
- RETURN(-EEXIST);
- }
-
- if (rc != -ENOENT)
- RETURN(rc);
- }
-
- tgt = __lmv_locate_tgt(lmv, op_data->op_mea2, op_data->op_name,
- op_data->op_namelen, &op_data->op_fid2,
- &op_data->op_mds, true);
+ tgt = lmv_locate_tgt2(lmv, op_data);
if (IS_ERR(tgt))
RETURN(PTR_ERR(tgt));
if (IS_ERR(parent_tgt))
RETURN(PTR_ERR(parent_tgt));
- if (lsm) {
+ if (lmv_dir_striped(lsm)) {
__u32 hash_type = lsm->lsm_md_hash_type;
__u32 stripe_count = lsm->lsm_md_stripe_count;
* old stripes are appended after new stripes for migrating
* directory.
*/
- if (lsm->lsm_md_hash_type & LMV_HASH_FLAG_MIGRATION) {
+ if (lmv_dir_migrating(lsm)) {
hash_type = lsm->lsm_md_migrate_hash;
stripe_count -= lsm->lsm_md_migrate_offset;
}
if (rc < 0)
RETURN(rc);
- if (lsm->lsm_md_hash_type & LMV_HASH_FLAG_MIGRATION)
+ if (lmv_dir_migrating(lsm))
rc += lsm->lsm_md_migrate_offset;
/* save it in fid4 temporarily for early cancel */
* if parent is being migrated too, fill op_fid2 with target
* stripe fid, otherwise the target stripe is not created yet.
*/
- if (lsm->lsm_md_hash_type & LMV_HASH_FLAG_MIGRATION) {
+ if (lmv_dir_migrating(lsm)) {
hash_type = lsm->lsm_md_hash_type &
~LMV_HASH_FLAG_MIGRATION;
stripe_count = lsm->lsm_md_migrate_offset;
op_data->op_fsgid = from_kgid(&init_user_ns, current_fsgid());
op_data->op_cap = cfs_curproc_cap_pack();
- if (lmv_is_dir_migrating(op_data->op_mea2)) {
- struct lu_fid fid1 = op_data->op_fid1;
- struct lmv_stripe_md *lsm1 = op_data->op_mea1;
+ op_data->op_name = new;
+ op_data->op_namelen = newlen;
- /*
- * we avoid creating new file under old layout of migrating
- * directory, if there is an existing file with new name under
- * old layout, we can't unlink file in old layout and rename to
- * new layout in one transaction, so return -EBUSY here.`
- */
- tgt = __lmv_locate_tgt(lmv, op_data->op_mea2, new, newlen,
- &op_data->op_fid2, &op_data->op_mds,
- false);
- if (IS_ERR(tgt))
- RETURN(PTR_ERR(tgt));
-
- op_data->op_fid1 = op_data->op_fid2;
- op_data->op_mea1 = op_data->op_mea2;
- op_data->op_name = new;
- op_data->op_namelen = newlen;
- rc = md_getattr_name(tgt->ltd_exp, op_data, request);
- op_data->op_fid1 = fid1;
- op_data->op_mea1 = lsm1;
- op_data->op_name = NULL;
- op_data->op_namelen = 0;
- if (!rc) {
- ptlrpc_req_finished(*request);
- *request = NULL;
- RETURN(-EBUSY);
- }
-
- if (rc != -ENOENT)
- RETURN(rc);
- }
-
- /* rename to new layout for migrating directory */
- tp_tgt = __lmv_locate_tgt(lmv, op_data->op_mea2, new, newlen,
- &op_data->op_fid2, &op_data->op_mds, true);
+ tp_tgt = lmv_locate_tgt2(lmv, op_data);
if (IS_ERR(tp_tgt))
RETURN(PTR_ERR(tp_tgt));
RETURN(rc);
}
+ op_data->op_name = old;
+ op_data->op_namelen = oldlen;
retry:
- sp_tgt = __lmv_locate_tgt(lmv, op_data->op_mea1, old, oldlen,
- &op_data->op_fid1, &op_data->op_mds,
- op_data->op_post_migrate);
+ sp_tgt = lmv_locate_tgt(lmv, op_data);
if (IS_ERR(sp_tgt))
RETURN(PTR_ERR(sp_tgt));
struct md_callback *cb_op, __u64 offset,
struct page **ppage)
{
- struct obd_device *obd = exp->exp_obd;
- struct lmv_obd *lmv = &obd->u.lmv;
- struct lmv_stripe_md *lsm = op_data->op_mea1;
- struct lmv_tgt_desc *tgt;
- int rc;
+ struct obd_device *obd = exp->exp_obd;
+ struct lmv_obd *lmv = &obd->u.lmv;
+ struct lmv_tgt_desc *tgt;
+ int rc;
+
ENTRY;
- if (unlikely(lsm != NULL)) {
- /* foreign dir is not striped dir */
- if (lsm->lsm_md_magic == LMV_MAGIC_FOREIGN)
- return -ENODATA;
+ if (unlikely(lmv_dir_foreign(op_data->op_mea1)))
+ RETURN(-ENODATA);
+ if (unlikely(lmv_dir_striped(op_data->op_mea1))) {
rc = lmv_striped_read_page(exp, op_data, cb_op, offset, ppage);
RETURN(rc);
}
op_data->op_cap = cfs_curproc_cap_pack();
retry:
- parent_tgt = lmv_locate_tgt(lmv, op_data, &op_data->op_fid1);
+ parent_tgt = lmv_locate_tgt(lmv, op_data);
if (IS_ERR(parent_tgt))
RETURN(PTR_ERR(parent_tgt));
RETURN(0);
}
- if (lsm->lsm_md_magic == LMV_MAGIC) {
+ if (lmv_dir_striped(lsm)) {
for (i = 0; i < lsm->lsm_md_stripe_count; i++) {
if (lsm->lsm_md_oinfo[i].lmo_root)
iput(lsm->lsm_md_oinfo[i].lmo_root);
{
const struct lmv_oinfo *oinfo;
- LASSERT(lsm != NULL);
+ LASSERT(lmv_dir_striped(lsm));
+
oinfo = lsm_name_to_stripe_info(lsm, name, namelen, false);
if (IS_ERR(oinfo))
return PTR_ERR(oinfo);
int rc;
int i;
- /* foreign dir is not striped dir */
- if (lsm->lsm_md_magic == LMV_MAGIC_FOREIGN)
+ if (!lmv_dir_striped(lsm))
return 0;
rc = lmv_revalidate_slaves(exp, lsm, cb_blocking, 0);