- add another sanity test

[fs/lustre-release.git] / lustre / llite / dcache.c

diff --git a/lustre/llite/dcache.c b/lustre/llite/dcache.c
index 02e78ae..53c0ef4 100644 (file)
--- a/lustre/llite/dcache.c
+++ b/lustre/llite/dcache.c
@@ -28,6 +28,7 @@
 
 #include <linux/obd_support.h>
 #include <linux/lustre_lite.h>
+#include <linux/lustre_idl.h>
 #include <linux/lustre_dlm.h>
 
 extern struct address_space_operations ll_aops;
@@ -40,12 +41,16 @@ void ll_release(struct dentry *de)
         EXIT;
 }
 
+extern void d_delete_aliases(struct inode *);
 void ll_intent_release(struct dentry *de, struct lookup_intent *it)
 {
         struct lustre_handle *handle;
         ENTRY;
 
-        if (it == NULL) {
+        /* XXX the check for RENAME2 is a workaround for old kernels 
+           which call intent_release twice in rename 
+        */
+        if (it == NULL || it->it_op == IT_RENAME2) {
                 EXIT;
                 return;
         }
@@ -63,68 +68,97 @@ void ll_intent_release(struct dentry *de, struct lookup_intent *it)
                 } else
                         ldlm_lock_decref(handle, it->it_lock_mode);
         }
-        //up(&ll_d2d(de)->lld_it_sem);
+
+        if (it->it_op == IT_RELEASED_MAGIC) {
+                EXIT; 
+                return;
+        }
+
+        if (de->d_it && de->d_it == it) { 
+                de->d_it = NULL;
+                up(&ll_d2d(de)->lld_it_sem);
+                it->it_op = IT_RELEASED_MAGIC;
+        }
+
         EXIT;
 }
 
-int ll_revalidate2(struct dentry *de, int flags, struct lookup_intent *it)
+extern struct dentry *ll_find_alias(struct inode *, struct dentry *);
+
+static int revalidate2_finish(int flag, struct ptlrpc_request *request, 
+                          struct dentry **de,
+                          struct lookup_intent *it, 
+                          int offset, obd_id ino)
+{
+        ldlm_lock_set_data((struct lustre_handle *)it->it_lock_handle,
+                           (*de)->d_inode, sizeof(*((*de)->d_inode)));
+        ptlrpc_req_finished(request);
+        return 0;
+}
+
+static int ll_have_lock(struct dentry *de)
 {
-        struct ll_sb_info *sbi = ll_s2sbi(de->d_sb);
+       struct ll_sb_info *sbi = ll_s2sbi(de->d_sb);
         struct lustre_handle lockh;
         __u64 res_id[RES_NAME_SIZE] = {0};
         struct obd_device *obddev;
-        int rc = 0;
         ENTRY;
 
-        if (it) {
-                CDEBUG(D_INFO, "name: %*s, intent: %s\n", de->d_name.len,
-                       de->d_name.name, ldlm_it2str(it->it_op));
-                if (it->it_op == IT_RENAME)
-                        it->it_data = de;
-        }
-
-        if (!de->d_inode)
-                GOTO(out, rc = 0);
+       if (!de->d_inode)
+               RETURN(0);
 
         obddev = class_conn2obd(&sbi->ll_mdc_conn);
         res_id[0] = de->d_inode->i_ino;
 
         CDEBUG(D_INFO, "trying to match res "LPU64"\n", res_id[0]);
 
-        if (ldlm_lock_match(obddev->obd_namespace, res_id, LDLM_MDSINTENT,
+        if (ldlm_lock_match(obddev->obd_namespace, res_id, LDLM_PLAIN,
                             NULL, 0, LCK_PR, &lockh)) {
                 ldlm_lock_decref(&lockh, LCK_PR);
-                GOTO(out, rc = 1);
+                RETURN(1);
         }
 
-        if (ldlm_lock_match(obddev->obd_namespace, res_id, LDLM_MDSINTENT,
+        if (ldlm_lock_match(obddev->obd_namespace, res_id, LDLM_PLAIN,
                             NULL, 0, LCK_PW, &lockh)) {
                 ldlm_lock_decref(&lockh, LCK_PW);
-                GOTO(out, rc = 1);
+                RETURN(1);
+        }
+        RETURN(0);
+}
+
+int ll_revalidate2(struct dentry *de, int flags, struct lookup_intent *it)
+{
+        int rc;
+        ENTRY;
+
+        /* We don't want to cache negative dentries, so return 0 immediately.
+         * We believe that this is safe, that negative dentries cannot be
+         * pinned by someone else */
+        if (de->d_inode == NULL) {
+                CDEBUG(D_INODE, "negative dentry: ret 0 to force lookup2\n");
+                RETURN(0);
         }
 
-        /* If the dentry is busy, we won't get called in lookup2 if we
-         * return 0, so return 1.
-         *
-         * This is a temporary fix for bug 618962, but is one of the causes of
-         * 619078. */
-        CDEBUG(D_INFO, "d_count: %d\n", atomic_read(&de->d_count));
-        if (it && atomic_read(&de->d_count) > 1) {
-                CDEBUG(D_INFO, "returning 1 for %*s during %s because d_count "
-                       "is %d\n", de->d_name.len, de->d_name.name,
-                       ldlm_it2str(it->it_op), atomic_read(&de->d_count));
-                GOTO(out, rc = 1);
+        if (ll_have_lock(de))
+                GOTO(out, rc = 0);
+
+        rc = ll_intent_lock(de->d_parent->d_inode, &de, it, revalidate2_finish);
+        if (rc < 0) {
+                /* Something bad happened; overwrite it_status? */
+                CERROR("ll_intent_lock: %d\n", rc);
         }
+        /* unfortunately ll_intent_lock may cause a callback and revoke our 
+           dentry */
+        spin_lock(&dcache_lock);
+        list_del_init(&de->d_hash);
+        spin_unlock(&dcache_lock);
+        d_rehash(de);
 
  out:
-        if (ll_d2d(de) == NULL) {
-                CERROR("allocating fsdata\n");
-                ll_set_dd(de);
-        }
-        //down(&ll_d2d(de)->lld_it_sem);
-        de->d_it = it;
+        if (!it)
+                de->d_it = NULL;
 
-        RETURN(rc);
+        RETURN(1);
 }
 
 int ll_set_dd(struct dentry *de)