#include "lfsck_internal.h"
-static int lfsck_unpack_ent(struct lu_dirent *ent, __u64 *cookie, __u16 *type)
+int lfsck_unpack_ent(struct lu_dirent *ent, __u64 *cookie, __u16 *type)
{
struct luda_type *lt;
int align = sizeof(*lt) - 1;
iops->put(env, di);
}
-static void lfsck_close_dir(const struct lu_env *env,
- struct lfsck_instance *lfsck)
-{
- struct dt_object *dir_obj = lfsck->li_obj_dir;
- const struct dt_it_ops *dir_iops = &dir_obj->do_index_ops->dio_it;
- struct dt_it *dir_di = lfsck->li_di_dir;
-
- lfsck_di_dir_put(env, lfsck);
- dir_iops->fini(env, dir_di);
- lfsck->li_obj_dir = NULL;
- lfsck_object_put(env, dir_obj);
-}
-
static int lfsck_update_lma(const struct lu_env *env,
struct lfsck_instance *lfsck, struct dt_object *obj)
{
(const struct dt_key *)"..", BYPASS_CAPA);
}
+/**
+ * Check whether needs to scan the directory or not.
+ *
+ * 1) If we are not doing namespace LFSCK, or the given @obj is not directory,
+ * then needs not to scan the @obj. Otherwise,
+ * 2) Global /ROOT needs to be scanned, backend root needs not to be scanned.
+ * 3) If the @obj is neither IGIF nor normal FID (including .lustre and its
+ * sub-directories that have been scanned when the LFSCK engine start),
+ * then needs not to be scanned.
+ * 4) If it is a remote object, then scanning the object will be done on the
+ * MDT on which the object really resides.
+ * 5) If the local object has normal FID, then needs to be scanned. Otherwise,
+ * 6) If the object has linkEA, then needs to be scanned. Otherwise,
+ * 7) If none of the previous conditions are true, we need to check the parent
+ * directories whether this subdirectory is in a tree that should be scanned.
+ * Set the parent as current @obj, repeat 2)-7).
+ *
+ * \param[in] env pointer to the thread context
+ * \param[in] lfsck pointer to the lfsck instance
+ * \param[in] obj pointer to the object to be checked
+ *
+ * \retval positive number if the directory needs to be scanned
+ * \retval 0 if the directory needs NOT to be scanned
+ * \retval negative error number on failure
+ */
static int lfsck_needs_scan_dir(const struct lu_env *env,
struct lfsck_instance *lfsck,
struct dt_object *obj)
{
- struct lu_fid *fid = &lfsck_env_info(env)->lti_fid;
- int depth = 0;
- int rc;
+ struct lfsck_thread_info *info = lfsck_env_info(env);
+ struct lu_fid *fid = &info->lti_fid;
+ struct lu_seq_range *range = &info->lti_range;
+ struct dt_device *dev = lfsck->li_bottom;
+ struct seq_server_site *ss = lu_site2seq(dev->dd_lu_dev.ld_site);
+ __u32 idx = lfsck_dev_idx(dev);
+ int depth = 0;
+ int rc = 0;
if (list_empty(&lfsck->li_list_dir) || !S_ISDIR(lfsck_object_type(obj)))
- RETURN(0);
+ return 0;
+
+ LASSERT(ss != NULL);
+ *fid = *lfsck_dto2fid(obj);
while (1) {
- /* XXX: Currently, we do not scan the "/REMOTE_PARENT_DIR",
- * which is the agent directory to manage the objects
- * which name entries reside on remote MDTs. Related
- * consistency verification will be processed in LFSCK
- * phase III. */
- if (lu_fid_eq(lfsck_dto2fid(obj), &lfsck->li_global_root_fid)) {
- if (depth > 0)
- lfsck_object_put(env, obj);
+ /* Global /ROOT is visible. */
+ if (unlikely(lu_fid_eq(fid, &lfsck->li_global_root_fid)))
return 1;
- }
- /* No need to check .lustre and its children. */
- if (fid_seq_is_dot(fid_seq(lfsck_dto2fid(obj)))) {
- if (depth > 0)
- lfsck_object_put(env, obj);
+ /* Backend root is invisible. */
+ if (unlikely(lu_fid_eq(fid, &lfsck->li_local_root_fid)))
+ return 0;
+
+ if (!fid_is_norm(fid) && !fid_is_igif(fid))
return 0;
+
+ fld_range_set_mdt(range);
+ rc = fld_local_lookup(env, ss->ss_server_fld,
+ fid_seq(fid), range);
+ if (rc != 0 || range->lsr_index != idx)
+ /* Current FID should NOT be for the input parameter
+ * @obj, because the lfsck_master_oit_engine() has
+ * filtered out agent object. So current FID is for
+ * the ancestor of the original input parameter @obj.
+ * So the ancestor is a remote directory. The input
+ * parameter @obj is local directory, and should be
+ * scanned under such case. */
+ return 1;
+
+ /* normal FID on this target (locally) must be for the
+ * client-side visiable object. */
+ if (fid_is_norm(fid))
+ return 1;
+
+ if (obj == NULL) {
+ obj = lfsck_object_find(env, lfsck, fid);
+ if (IS_ERR(obj))
+ return PTR_ERR(obj);
+
+ depth++;
+ if (!dt_object_exists(obj))
+ GOTO(out, rc = 0);
}
dt_read_lock(env, obj, MOR_TGT_CHILD);
if (unlikely(lfsck_is_dead_obj(obj))) {
dt_read_unlock(env, obj);
- if (depth > 0)
- lfsck_object_put(env, obj);
- return 0;
+
+ GOTO(out, rc = 0);
}
rc = dt_xattr_get(env, obj,
lfsck_buf_get(env, NULL, 0), XATTR_NAME_LINK,
BYPASS_CAPA);
dt_read_unlock(env, obj);
- if (rc >= 0) {
- if (depth > 0)
- lfsck_object_put(env, obj);
- return 1;
- }
+ if (rc >= 0)
+ GOTO(out, rc = 1);
- if (rc < 0 && rc != -ENODATA) {
- if (depth > 0)
- lfsck_object_put(env, obj);
- return rc;
- }
+ if (rc < 0 && rc != -ENODATA)
+ GOTO(out, rc);
rc = lfsck_parent_fid(env, obj, fid);
if (depth > 0)
lfsck_object_put(env, obj);
+
+ obj = NULL;
if (rc != 0)
return rc;
- if (unlikely(lu_fid_eq(fid, &lfsck->li_local_root_fid)))
+ if (!fid_is_sane(fid))
return 0;
+ }
- obj = lfsck_object_find(env, lfsck, fid);
- if (IS_ERR(obj))
- return PTR_ERR(obj);
+out:
+ if (depth > 0 && obj != NULL)
+ lfsck_object_put(env, obj);
- if (!dt_object_exists(obj)) {
- lfsck_object_put(env, obj);
- return 0;
+ return rc;
+}
+
+static int lfsck_load_stripe_lmv(const struct lu_env *env,
+ struct lfsck_instance *lfsck,
+ struct dt_object *obj)
+{
+ struct lmv_mds_md_v1 *lmv = &lfsck_env_info(env)->lti_lmv;
+ struct lfsck_lmv *llmv;
+ int rc;
+ ENTRY;
+
+ LASSERT(lfsck->li_obj_dir == NULL);
+ LASSERT(lfsck->li_lmv == NULL);
+
+ rc = lfsck_read_stripe_lmv(env, obj, lmv);
+ if (rc == -ENODATA) {
+ lfsck->li_obj_dir = lfsck_object_get(obj);
+
+ RETURN(0);
+ }
+
+ if (rc < 0)
+ RETURN(rc);
+
+ OBD_ALLOC_PTR(llmv);
+ if (llmv == NULL)
+ RETURN(-ENOMEM);
+
+ if (lmv->lmv_magic == LMV_MAGIC) {
+ struct lfsck_slave_lmv_rec *lslr;
+ __u32 stripes;
+
+ llmv->ll_lmv_master = 1;
+ if (lmv->lmv_stripe_count < 1)
+ stripes = LFSCK_LMV_DEF_STRIPES;
+ else if (lmv->lmv_stripe_count > LFSCK_LMV_MAX_STRIPES)
+ stripes = LFSCK_LMV_MAX_STRIPES;
+ else
+ stripes = lmv->lmv_stripe_count;
+
+ OBD_ALLOC_LARGE(lslr, sizeof(*lslr) * stripes);
+ if (lslr == NULL) {
+ OBD_FREE_PTR(llmv);
+
+ RETURN(-ENOMEM);
}
- if (dt_object_remote(obj)) {
- /* .lustre/lost+found/MDTxxx can be remote directory. */
- if (fid_seq_is_dot(fid_seq(lfsck_dto2fid(obj))))
- rc = 0;
- else
- /* Other remote directory should be client
- * visible and need to be checked. */
- rc = 1;
- lfsck_object_put(env, obj);
- return rc;
+ /* Find the object against the bottom device. */
+ obj = lfsck_object_find_by_dev(env, lfsck->li_bottom,
+ lfsck_dto2fid(obj));
+ if (IS_ERR(obj)) {
+ OBD_FREE_LARGE(lslr, sizeof(*lslr) * stripes);
+ OBD_FREE_PTR(llmv);
+
+ RETURN(PTR_ERR(obj));
}
- depth++;
+ llmv->ll_stripes_allocated = stripes;
+ llmv->ll_hash_type = LMV_HASH_TYPE_UNKNOWN;
+ llmv->ll_lslr = lslr;
+ lfsck->li_obj_dir = obj;
+ } else {
+ llmv->ll_lmv_slave = 1;
+ lfsck->li_obj_dir = lfsck_object_get(obj);
}
- return 0;
+
+ llmv->ll_lmv = *lmv;
+ atomic_set(&llmv->ll_ref, 1);
+ lfsck->li_lmv = llmv;
+
+ RETURN(0);
}
/* LFSCK wrap functions */
}
}
+void lfsck_close_dir(const struct lu_env *env,
+ struct lfsck_instance *lfsck, int result)
+{
+ struct lfsck_component *com;
+ ENTRY;
+
+ if (lfsck->li_lmv != NULL) {
+ lfsck->li_lmv->ll_exit_value = result;
+ if (lfsck->li_obj_dir != NULL) {
+ list_for_each_entry(com, &lfsck->li_list_dir,
+ lc_link_dir) {
+ com->lc_ops->lfsck_close_dir(env, com);
+ }
+ }
+
+ lfsck_lmv_put(env, lfsck->li_lmv);
+ lfsck->li_lmv = NULL;
+ }
+
+ if (lfsck->li_di_dir != NULL) {
+ const struct dt_it_ops *dir_iops;
+ struct dt_it *dir_di = lfsck->li_di_dir;
+
+ LASSERT(lfsck->li_obj_dir != NULL);
+
+ dir_iops = &lfsck->li_obj_dir->do_index_ops->dio_it;
+ lfsck_di_dir_put(env, lfsck);
+ dir_iops->fini(env, dir_di);
+ }
+
+ if (lfsck->li_obj_dir != NULL) {
+ struct dt_object *dir_obj = lfsck->li_obj_dir;
+
+ lfsck->li_obj_dir = NULL;
+ lfsck_object_put(env, dir_obj);
+ }
+
+ EXIT;
+}
+
+int lfsck_open_dir(const struct lu_env *env,
+ struct lfsck_instance *lfsck, __u64 cookie)
+{
+ struct dt_object *obj = lfsck->li_obj_dir;
+ struct dt_it *di = lfsck->li_di_dir;
+ struct lfsck_component *com;
+ const struct dt_it_ops *iops;
+ int rc = 0;
+ ENTRY;
+
+ LASSERT(obj != NULL);
+ LASSERT(di == NULL);
+
+ if (unlikely(!dt_try_as_dir(env, obj)))
+ GOTO(out, rc = -ENOTDIR);
+
+ list_for_each_entry(com, &lfsck->li_list_dir, lc_link_dir) {
+ rc = com->lc_ops->lfsck_open_dir(env, com);
+ if (rc != 0)
+ GOTO(out, rc);
+ }
+
+ iops = &obj->do_index_ops->dio_it;
+ di = iops->init(env, obj, lfsck->li_args_dir, BYPASS_CAPA);
+ if (IS_ERR(di))
+ GOTO(out, rc = PTR_ERR(di));
+
+ rc = iops->load(env, di, cookie);
+ if (rc == 0 || (rc > 0 && cookie > 0))
+ rc = iops->next(env, di);
+ else if (rc > 0)
+ rc = 0;
+
+ if (rc != 0) {
+ iops->put(env, di);
+ iops->fini(env, di);
+ } else {
+ lfsck->li_cookie_dir = iops->store(env, di);
+ spin_lock(&lfsck->li_lock);
+ lfsck->li_di_dir = di;
+ spin_unlock(&lfsck->li_lock);
+ }
+
+ GOTO(out, rc);
+
+out:
+ if (rc != 0)
+ lfsck_close_dir(env, lfsck, rc);
+
+ return rc;
+}
+
static int lfsck_checkpoint(const struct lu_env *env,
struct lfsck_instance *lfsck)
{
struct lfsck_position *pos = NULL;
const struct dt_it_ops *iops =
&lfsck->li_obj_oit->do_index_ops->dio_it;
- struct dt_it *di;
int rc;
ENTRY;
lfsck->li_current_oit_processed = 0;
list_for_each_entry_safe(com, next, &lfsck->li_list_scan, lc_link) {
com->lc_new_checked = 0;
- if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN)
- com->lc_journal = 0;
-
rc = com->lc_ops->lfsck_prep(env, com, lsp);
if (rc != 0)
GOTO(out, rc);
if (IS_ERR(obj))
RETURN(PTR_ERR(obj));
- /* XXX: Currently, skip remote object, the consistency for
- * remote object will be processed in LFSCK phase III. */
+ /* Remote directory will be scanned by the LFSCK instance
+ * on the MDT where the remote object really resides on. */
if (!dt_object_exists(obj) || dt_object_remote(obj) ||
unlikely(!S_ISDIR(lfsck_object_type(obj))))
GOTO(out, rc = 0);
- if (unlikely(!dt_try_as_dir(env, obj)))
- GOTO(out, rc = -ENOTDIR);
-
- /* Init the namespace-based directory traverse. */
- iops = &obj->do_index_ops->dio_it;
- di = iops->init(env, obj, lfsck->li_args_dir, BYPASS_CAPA);
- if (IS_ERR(di))
- GOTO(out, rc = PTR_ERR(di));
-
- LASSERT(pos->lp_dir_cookie < MDS_DIR_END_OFF);
+ rc = lfsck_load_stripe_lmv(env, lfsck, obj);
+ if (rc == 0) {
+ /* For the master MDT-object of a striped directory,
+ * reset the iteration from the directory beginning. */
+ if (lfsck->li_lmv != NULL && lfsck->li_lmv->ll_lmv_master)
+ pos->lp_dir_cookie = 0;
- rc = iops->load(env, di, pos->lp_dir_cookie);
- if ((rc == 0) || (rc > 0 && pos->lp_dir_cookie > 0))
- rc = iops->next(env, di);
- else if (rc > 0)
- rc = 0;
-
- if (rc != 0) {
- iops->put(env, di);
- iops->fini(env, di);
- GOTO(out, rc);
+ rc = lfsck_open_dir(env, lfsck, pos->lp_dir_cookie);
+ if (rc > 0)
+ /* The end of the directory. */
+ rc = 0;
}
- lfsck->li_obj_dir = lfsck_object_get(obj);
- lfsck->li_cookie_dir = iops->store(env, di);
- spin_lock(&lfsck->li_lock);
- lfsck->li_di_dir = di;
- spin_unlock(&lfsck->li_lock);
-
- GOTO(out, rc = 0);
+ GOTO(out, rc);
out:
if (obj != NULL)
lfsck_object_put(env, obj);
- if (rc < 0) {
+ if (rc != 0) {
+ lfsck_close_dir(env, lfsck, rc);
list_for_each_entry_safe(com, next, &lfsck->li_list_scan,
- lc_link)
+ lc_link) {
com->lc_ops->lfsck_post(env, com, rc, true);
+ }
return rc;
}
struct lfsck_instance *lfsck, struct dt_object *obj)
{
struct lfsck_component *com;
- const struct dt_it_ops *iops;
- struct dt_it *di;
int rc;
ENTRY;
if (rc <= 0)
GOTO(out, rc);
- if (unlikely(!dt_try_as_dir(env, obj)))
- GOTO(out, rc = -ENOTDIR);
-
- iops = &obj->do_index_ops->dio_it;
- di = iops->init(env, obj, lfsck->li_args_dir, BYPASS_CAPA);
- if (IS_ERR(di))
- GOTO(out, rc = PTR_ERR(di));
-
- rc = iops->load(env, di, 0);
+ rc = lfsck_load_stripe_lmv(env, lfsck, obj);
if (rc == 0)
- rc = iops->next(env, di);
- else if (rc > 0)
- rc = 0;
+ rc = lfsck_open_dir(env, lfsck, 0);
- if (rc != 0) {
- iops->put(env, di);
- iops->fini(env, di);
- GOTO(out, rc);
- }
-
- lfsck->li_obj_dir = lfsck_object_get(obj);
- lfsck->li_cookie_dir = iops->store(env, di);
- spin_lock(&lfsck->li_lock);
- lfsck->li_di_dir = di;
- spin_unlock(&lfsck->li_lock);
-
- GOTO(out, rc = 0);
+ GOTO(out, rc);
out:
if (rc < 0)
lfsck_fail(env, lfsck, false);
- return (rc > 0 ? 0 : rc);
+
+ if (rc != 0)
+ lfsck_close_dir(env, lfsck, rc);
+
+ return rc > 0 ? 0 : rc;
}
static int lfsck_exec_dir(const struct lu_env *env,
return 0;
}
+static int lfsck_master_dir_engine(const struct lu_env *env,
+ struct lfsck_instance *lfsck);
+
static int lfsck_post(const struct lu_env *env, struct lfsck_instance *lfsck,
int result)
{
struct lfsck_component *com;
struct lfsck_component *next;
- int rc = 0;
- int rc1 = 0;
+ int rc = result;
lfsck_pos_fill(env, lfsck, &lfsck->li_pos_checkpoint, false);
+ lfsck_close_dir(env, lfsck, result);
+
+ while (thread_is_running(&lfsck->li_thread) && rc > 0 &&
+ !list_empty(&lfsck->li_list_lmv)) {
+ struct lfsck_lmv_unit *llu;
+
+ spin_lock(&lfsck->li_lock);
+ llu = list_entry(lfsck->li_list_lmv.next,
+ struct lfsck_lmv_unit, llu_link);
+ list_del_init(&llu->llu_link);
+ spin_unlock(&lfsck->li_lock);
+
+ lfsck->li_lmv = &llu->llu_lmv;
+ lfsck->li_obj_dir = lfsck_object_get(llu->llu_obj);
+ rc = lfsck_open_dir(env, lfsck, 0);
+ if (rc == 0) {
+ rc = lfsck_master_dir_engine(env, lfsck);
+ lfsck_close_dir(env, lfsck, result);
+ }
+ }
+
+ result = rc;
+
list_for_each_entry_safe(com, next, &lfsck->li_list_scan, lc_link) {
rc = com->lc_ops->lfsck_post(env, com, result, false);
if (rc != 0)
- rc1 = rc;
+ CDEBUG(D_LFSCK, "%s: lfsck_post at the component %u: "
+ "rc = %d\n", lfsck_lfsck2name(lfsck),
+ (__u32)com->lc_type, rc);
}
lfsck->li_time_last_checkpoint = cfs_time_current();
int rc1 = 0;
list_for_each_entry(com, &lfsck->li_list_double_scan, lc_link) {
- if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN)
- com->lc_journal = 0;
-
rc = com->lc_ops->lfsck_double_scan(env, com);
if (rc != 0)
rc1 = rc;
l_wait_event(thread->t_ctl_waitq,
!thread_is_running(thread),
&lwi);
+
+ if (unlikely(!thread_is_running(thread))) {
+ CDEBUG(D_LFSCK, "%s: scan dir exit for engine "
+ "stop, parent "DFID", cookie "LPX64"\n",
+ lfsck_lfsck2name(lfsck),
+ PFID(lfsck_dto2fid(dir)),
+ lfsck->li_cookie_dir);
+ RETURN(0);
+ }
}
lfsck->li_new_scanned++;
goto checkpoint;
}
- if (ent->lde_attrs & LUDA_IGNORE)
+ if (ent->lde_attrs & LUDA_IGNORE &&
+ strcmp(ent->lde_name, dotdot) != 0)
goto checkpoint;
/* The type in the @ent structure may has been overwritten,
} while (rc == 0);
if (rc > 0 && !lfsck->li_oit_over)
- lfsck_close_dir(env, lfsck);
+ lfsck_close_dir(env, lfsck, rc);
RETURN(rc);
}
+/**
+ * Object-table based iteration engine.
+ *
+ * Object-table based iteration is the basic linear engine to scan all the
+ * objects on current device in turn. For each object, it calls all the
+ * registered LFSCK component(s)' API to perform related consistency
+ * verification.
+ *
+ * It flushes related LFSCK trace files to disk via making checkpoint
+ * periodically. Then if the server crashed or the LFSCK is paused, the
+ * LFSCK can resume from the latest checkpoint.
+ *
+ * It also controls the whole LFSCK speed via lfsck_control_speed() to
+ * avoid the server to become overload.
+ *
+ * \param[in] env pointer to the thread context
+ * \param[in] lfsck pointer to the lfsck instance
+ *
+ * \retval positive number if all objects have been scanned
+ * \retval 0 if the iteration is stopped or paused
+ * \retval negative error number on failure
+ */
static int lfsck_master_oit_engine(const struct lu_env *env,
struct lfsck_instance *lfsck)
{
- struct lfsck_thread_info *info = lfsck_env_info(env);
- const struct dt_it_ops *iops =
+ struct lfsck_thread_info *info = lfsck_env_info(env);
+ const struct dt_it_ops *iops =
&lfsck->li_obj_oit->do_index_ops->dio_it;
- struct dt_it *di = lfsck->li_di_oit;
- struct lu_fid *fid = &info->lti_fid;
- struct lfsck_bookmark *bk = &lfsck->li_bookmark_ram;
- struct ptlrpc_thread *thread = &lfsck->li_thread;
- __u32 idx =
- lfsck_dev_idx(lfsck->li_bottom);
- int rc;
+ struct dt_it *di = lfsck->li_di_oit;
+ struct lu_fid *fid = &info->lti_fid;
+ struct lfsck_bookmark *bk = &lfsck->li_bookmark_ram;
+ struct ptlrpc_thread *thread = &lfsck->li_thread;
+ struct dt_device *dev = lfsck->li_bottom;
+ struct seq_server_site *ss = lu_site2seq(dev->dd_lu_dev.ld_site);
+ __u32 idx = lfsck_dev_idx(dev);
+ int rc;
ENTRY;
+ if (unlikely(ss == NULL))
+ RETURN(-EIO);
+
do {
struct dt_object *target;
bool update_lma = false;
l_wait_event(thread->t_ctl_waitq,
!thread_is_running(thread),
&lwi);
+
+ if (unlikely(!thread_is_running(thread))) {
+ CDEBUG(D_LFSCK, "%s: OIT scan exit for engine "
+ "stop, cookie "LPU64"\n",
+ lfsck_lfsck2name(lfsck),
+ iops->store(env, di));
+ RETURN(0);
+ }
}
if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_CRASH))
RETURN(0);
lfsck->li_current_oit_processed = 1;
+
+ if (!list_empty(&lfsck->li_list_lmv)) {
+ struct lfsck_lmv_unit *llu;
+
+ spin_lock(&lfsck->li_lock);
+ llu = list_entry(lfsck->li_list_lmv.next,
+ struct lfsck_lmv_unit, llu_link);
+ list_del_init(&llu->llu_link);
+ spin_unlock(&lfsck->li_lock);
+
+ lfsck->li_lmv = &llu->llu_lmv;
+ lfsck->li_obj_dir = lfsck_object_get(llu->llu_obj);
+ rc = lfsck_open_dir(env, lfsck, 0);
+ if (rc == 0)
+ rc = lfsck_master_dir_engine(env, lfsck);
+
+ if (rc <= 0)
+ RETURN(rc);
+ }
+
lfsck->li_new_scanned++;
lfsck->li_pos_current.lp_oit_cookie = iops->store(env, di);
rc = iops->rec(env, di, (struct dt_rec *)fid, 0);
update_lma = true;
}
} else if (!fid_is_norm(fid) && !fid_is_igif(fid) &&
- !fid_is_last_id(fid) && !fid_is_root(fid) &&
- !fid_seq_is_dot(fid_seq(fid))) {
+ !fid_is_last_id(fid) &&
+ !lu_fid_eq(fid, &lfsck->li_global_root_fid)) {
+
/* If the FID/object is only used locally and invisible
- * to external nodes, then LFSCK will not handle it. */
+ * to external nodes, then LFSCK will not handle it.
+ *
+ * dot_lustre sequence has been handled specially. */
goto checkpoint;
+ } else {
+ struct lu_seq_range *range = &info->lti_range;
+
+ if (lfsck->li_master)
+ fld_range_set_mdt(range);
+ else
+ fld_range_set_ost(range);
+ rc = fld_local_lookup(env, ss->ss_server_fld,
+ fid_seq(fid), range);
+ if (rc != 0 || range->lsr_index != idx) {
+ /* Remote object will be handled by the LFSCK
+ * instance on the MDT where the remote object
+ * really resides on. */
+ rc = 0;
+ goto checkpoint;
+ }
}
target = lfsck_object_find(env, lfsck, fid);
goto checkpoint;
}
- /* XXX: Currently, skip remote object, the consistency for
- * remote object will be processed in LFSCK phase III. */
- if (dt_object_exists(target) && !dt_object_remote(target)) {
+ if (dt_object_exists(target)) {
if (update_lma) {
rc = lfsck_update_lma(env, lfsck, target);
if (rc != 0)
if (!OBD_FAIL_CHECK(OBD_FAIL_LFSCK_CRASH))
rc = lfsck_post(env, lfsck, rc);
-
- if (lfsck->li_di_dir != NULL)
- lfsck_close_dir(env, lfsck);
+ else
+ lfsck_close_dir(env, lfsck, rc);
fini_oit:
lfsck_di_oit_put(env, lfsck);
}
/**
- * Notify the LFSCK event to the instatnces on remote servers.
+ * Notify the LFSCK event to the instances on remote servers.
*
* The LFSCK assistant thread notifies the LFSCK instances on other
* servers (MDT/OST) about some events, such as start new scanning,
if (com->lc_type != LFSCK_TYPE_LAYOUT)
goto next;
- lr->lr_valid = LSV_SPEED_LIMIT | LSV_ERROR_HANDLE | LSV_DRYRUN |
- LSV_ASYNC_WINDOWS | LSV_CREATE_OSTOBJ;
+ lr->lr_valid = LSV_SPEED_LIMIT | LSV_ERROR_HANDLE | LSV_DRYRUN;
lr->lr_speed = bk->lb_speed_limit;
lr->lr_version = bk->lb_version;
lr->lr_param |= bk->lb_param;
list = <d->ltd_layout_list;
gen = <d->ltd_layout_gen;
} else {
+ struct lfsck_namespace *ns = com->lc_file_ram;
+
ltd = list_entry(lad->lad_mdt_list.next,
struct lfsck_tgt_desc,
ltd_namespace_list);
list = <d->ltd_namespace_list;
gen = <d->ltd_namespace_gen;
+ lr->lr_flags2 = ns->ln_flags & ~LF_INCOMPLETE;
}
if (*gen == lad->lad_touch_gen)
*gen = lad->lad_touch_gen;
list_move_tail(list, &lad->lad_mdt_list);
+ if (ltd->ltd_namespace_failed)
+ continue;
+
atomic_inc(<d->ltd_ref);
laia->laia_ltd = ltd;
spin_unlock(<ds->ltd_lock);
struct l_wait_info lwi = { 0 };
int rc = 0;
int rc1 = 0;
+ int rc2;
ENTRY;
CDEBUG(D_LFSCK, "%s: %s LFSCK assistant thread start\n",
com->lc_time_last_checkpoint +
cfs_time_seconds(LFSCK_CHECKPOINT_INTERVAL);
+ CDEBUG(D_LFSCK, "%s: LFSCK assistant sync before "
+ "the second-stage scaning\n",
+ lfsck_lfsck2name(lfsck));
+
/* Flush async updates before handling orphan. */
- dt_sync(env, lfsck->li_next);
+ rc2 = dt_sync(env, lfsck->li_next);
CDEBUG(D_LFSCK, "%s: LFSCK assistant phase2 "
- "scan start\n", lfsck_lfsck2name(lfsck));
+ "scan start, synced: rc = %d\n",
+ lfsck_lfsck2name(lfsck), rc2);
if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_NO_DOUBLESCAN))
GOTO(cleanup2, rc = 0);
rc = rc1;
}
+ CDEBUG(D_LFSCK, "%s: LFSCK assistant sync before exit\n",
+ lfsck_lfsck2name(lfsck));
+
/* Flush async updates before exit. */
- dt_sync(env, lfsck->li_next);
+ rc2 = dt_sync(env, lfsck->li_next);
+
+ CDEBUG(D_LFSCK, "%s: LFSCK assistant synced before exit: rc = %d\n",
+ lfsck_lfsck2name(lfsck), rc2);
/* Under force exit case, some requests may be just freed without
* verification, those objects should be re-handled when next run.
- * So not update the on-disk tracing file under such case. */
+ * So not update the on-disk trace file under such case. */
if (lad->lad_in_double_scan) {
if (!lad->lad_exit)
rc1 = lao->la_double_scan_result(env, com, rc);