Whamcloud - gitweb
LU-4107 build: fix lustre_user.h to C++ compatible
[fs/lustre-release.git] / lnet / selftest / conrpc.c
index 1213ef0..37455a2 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, Whamcloud, Inc.
+ * Copyright (c) 2011, 2012, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -54,39 +54,39 @@ void lstcon_rpc_stat_reply(lstcon_rpc_trans_t *, srpc_msg_t *,
 static void
 lstcon_rpc_done(srpc_client_rpc_t *rpc)
 {
-        lstcon_rpc_t *crpc = (lstcon_rpc_t *)rpc->crpc_priv;
+       lstcon_rpc_t *crpc = (lstcon_rpc_t *)rpc->crpc_priv;
 
-        LASSERT (crpc != NULL && rpc == crpc->crp_rpc);
-        LASSERT (crpc->crp_posted && !crpc->crp_finished);
+       LASSERT(crpc != NULL && rpc == crpc->crp_rpc);
+       LASSERT(crpc->crp_posted && !crpc->crp_finished);
 
-        cfs_spin_lock(&rpc->crpc_lock);
+       spin_lock(&rpc->crpc_lock);
 
-        if (crpc->crp_trans == NULL) {
-                /* Orphan RPC is not in any transaction, 
-                 * I'm just a poor body and nobody loves me */
-                cfs_spin_unlock(&rpc->crpc_lock);
+       if (crpc->crp_trans == NULL) {
+               /* Orphan RPC is not in any transaction,
+                * I'm just a poor body and nobody loves me */
+               spin_unlock(&rpc->crpc_lock);
 
-                /* release it */
-                lstcon_rpc_put(crpc);
-                return;
-        }
+               /* release it */
+               lstcon_rpc_put(crpc);
+               return;
+       }
 
-        /* not an orphan RPC */
-        crpc->crp_finished = 1;
+       /* not an orphan RPC */
+       crpc->crp_finished = 1;
 
-        if (crpc->crp_stamp == 0) {
-                /* not aborted */
-                LASSERT (crpc->crp_status == 0);
+       if (crpc->crp_stamp == 0) {
+               /* not aborted */
+               LASSERT (crpc->crp_status == 0);
 
-                crpc->crp_stamp  = cfs_time_current();
-                crpc->crp_status = rpc->crpc_status;
-        }
+               crpc->crp_stamp  = cfs_time_current();
+               crpc->crp_status = rpc->crpc_status;
+       }
 
-        /* wakeup (transaction)thread if I'm the last RPC in the transaction */
-        if (cfs_atomic_dec_and_test(&crpc->crp_trans->tas_remaining))
-                cfs_waitq_signal(&crpc->crp_trans->tas_waitq);
+       /* wakeup (transaction)thread if I'm the last RPC in the transaction */
+       if (atomic_dec_and_test(&crpc->crp_trans->tas_remaining))
+               wake_up(&crpc->crp_trans->tas_waitq);
 
-        cfs_spin_unlock(&rpc->crpc_lock);
+       spin_unlock(&rpc->crpc_lock);
 }
 
 int
@@ -109,7 +109,7 @@ lstcon_rpc_init(lstcon_node_t *nd, int service, unsigned feats,
        crpc->crp_embedded = embedded;
         CFS_INIT_LIST_HEAD(&crpc->crp_link);
 
-        cfs_atomic_inc(&console_session.ses_rpc_counter);
+       atomic_inc(&console_session.ses_rpc_counter);
 
         return 0;
 }
@@ -118,27 +118,26 @@ int
 lstcon_rpc_prep(lstcon_node_t *nd, int service, unsigned feats,
                int bulk_npg, int bulk_len, lstcon_rpc_t **crpcpp)
 {
-        lstcon_rpc_t  *crpc = NULL;
-        int            rc;
+       lstcon_rpc_t  *crpc = NULL;
+       int            rc;
 
-        cfs_spin_lock(&console_session.ses_rpc_lock);
+       spin_lock(&console_session.ses_rpc_lock);
 
-        if (!cfs_list_empty(&console_session.ses_rpc_freelist)) {
-                crpc = cfs_list_entry(console_session.ses_rpc_freelist.next,
-                                      lstcon_rpc_t, crp_link);
-                cfs_list_del_init(&crpc->crp_link);
-        }
+       if (!cfs_list_empty(&console_session.ses_rpc_freelist)) {
+               crpc = cfs_list_entry(console_session.ses_rpc_freelist.next,
+                                     lstcon_rpc_t, crp_link);
+               cfs_list_del_init(&crpc->crp_link);
+       }
 
-        cfs_spin_unlock(&console_session.ses_rpc_lock);
+       spin_unlock(&console_session.ses_rpc_lock);
 
-        if (crpc == NULL) {
-                LIBCFS_ALLOC(crpc, sizeof(*crpc));
-                if (crpc == NULL)
-                        return -ENOMEM;
-        }
+       if (crpc == NULL) {
+               LIBCFS_ALLOC(crpc, sizeof(*crpc));
+               if (crpc == NULL)
+                       return -ENOMEM;
+       }
 
-       rc = lstcon_rpc_init(nd, service, feats,
-                            bulk_npg, bulk_len, 0, crpc);
+       rc = lstcon_rpc_init(nd, service, feats, bulk_npg, bulk_len, 0, crpc);
         if (rc == 0) {
                 *crpcpp = crpc;
                 return 0;
@@ -161,7 +160,7 @@ lstcon_rpc_put(lstcon_rpc_t *crpc)
                 if (bulk->bk_iovs[i].kiov_page == NULL)
                         continue;
 
-                cfs_free_page(bulk->bk_iovs[i].kiov_page);
+               __free_page(bulk->bk_iovs[i].kiov_page);
         }
 
         srpc_client_rpc_decref(crpc->crp_rpc);
@@ -171,17 +170,17 @@ lstcon_rpc_put(lstcon_rpc_t *crpc)
                memset(crpc, 0, sizeof(*crpc));
                crpc->crp_embedded = 1;
 
-        } else {
-                cfs_spin_lock(&console_session.ses_rpc_lock);
+       } else {
+               spin_lock(&console_session.ses_rpc_lock);
 
-                cfs_list_add(&crpc->crp_link,
-                             &console_session.ses_rpc_freelist);
+               cfs_list_add(&crpc->crp_link,
+                            &console_session.ses_rpc_freelist);
 
-                cfs_spin_unlock(&console_session.ses_rpc_lock);
-        }
+               spin_unlock(&console_session.ses_rpc_lock);
+       }
 
-        /* RPC is not alive now */
-        cfs_atomic_dec(&console_session.ses_rpc_counter);
+       /* RPC is not alive now */
+       atomic_dec(&console_session.ses_rpc_counter);
 }
 
 void
@@ -191,7 +190,7 @@ lstcon_rpc_post(lstcon_rpc_t *crpc)
 
         LASSERT (trans != NULL);
 
-        cfs_atomic_inc(&trans->tas_remaining);
+       atomic_inc(&trans->tas_remaining);
         crpc->crp_posted = 1;
 
         sfw_post_rpc(crpc->crp_rpc);
@@ -266,13 +265,13 @@ lstcon_rpc_trans_prep(cfs_list_t *translist,
 
         cfs_list_add_tail(&trans->tas_link, &console_session.ses_trans_list);
 
-        CFS_INIT_LIST_HEAD(&trans->tas_rpcs_list);
-        cfs_atomic_set(&trans->tas_remaining, 0);
-        cfs_waitq_init(&trans->tas_waitq);
+       CFS_INIT_LIST_HEAD(&trans->tas_rpcs_list);
+       atomic_set(&trans->tas_remaining, 0);
+       init_waitqueue_head(&trans->tas_waitq);
 
-       cfs_spin_lock(&console_session.ses_rpc_lock);
+       spin_lock(&console_session.ses_rpc_lock);
        trans->tas_features = console_session.ses_features;
-       cfs_spin_unlock(&console_session.ses_rpc_lock);
+       spin_unlock(&console_session.ses_rpc_lock);
 
        *transpp = trans;
        return 0;
@@ -288,43 +287,43 @@ lstcon_rpc_trans_addreq(lstcon_rpc_trans_t *trans, lstcon_rpc_t *crpc)
 void
 lstcon_rpc_trans_abort(lstcon_rpc_trans_t *trans, int error)
 {
-        srpc_client_rpc_t *rpc;
-        lstcon_rpc_t      *crpc;
-        lstcon_node_t     *nd;
+       srpc_client_rpc_t *rpc;
+       lstcon_rpc_t      *crpc;
+       lstcon_node_t     *nd;
 
-        cfs_list_for_each_entry_typed (crpc, &trans->tas_rpcs_list,
-                                       lstcon_rpc_t, crp_link) {
-                rpc = crpc->crp_rpc;
+       cfs_list_for_each_entry_typed(crpc, &trans->tas_rpcs_list,
+                                     lstcon_rpc_t, crp_link) {
+               rpc = crpc->crp_rpc;
 
-                cfs_spin_lock(&rpc->crpc_lock);
+               spin_lock(&rpc->crpc_lock);
 
-                if (!crpc->crp_posted || /* not posted */
-                    crpc->crp_stamp != 0) { /* rpc done or aborted already */
-                        if (crpc->crp_stamp == 0) {
-                                crpc->crp_stamp = cfs_time_current();
-                                crpc->crp_status = -EINTR;
-                        }
-                        cfs_spin_unlock(&rpc->crpc_lock);
-                        continue;
-                }
+               if (!crpc->crp_posted || /* not posted */
+                   crpc->crp_stamp != 0) { /* rpc done or aborted already */
+                       if (crpc->crp_stamp == 0) {
+                               crpc->crp_stamp = cfs_time_current();
+                               crpc->crp_status = -EINTR;
+                       }
+                       spin_unlock(&rpc->crpc_lock);
+                       continue;
+               }
 
-                crpc->crp_stamp  = cfs_time_current();
-                crpc->crp_status = error;
+               crpc->crp_stamp  = cfs_time_current();
+               crpc->crp_status = error;
 
-                cfs_spin_unlock(&rpc->crpc_lock);
+               spin_unlock(&rpc->crpc_lock);
 
-                sfw_abort_rpc(rpc);
+               sfw_abort_rpc(rpc);
 
-                if  (error != ETIMEDOUT)
-                        continue;
+               if (error != -ETIMEDOUT)
+                       continue;
 
-                nd = crpc->crp_node;
-                if (cfs_time_after(nd->nd_stamp, crpc->crp_stamp))
-                        continue;
+               nd = crpc->crp_node;
+               if (cfs_time_after(nd->nd_stamp, crpc->crp_stamp))
+                       continue;
 
-                nd->nd_stamp = crpc->crp_stamp;
-                nd->nd_state = LST_NODE_DOWN;
-        }
+               nd->nd_stamp = crpc->crp_stamp;
+               nd->nd_state = LST_NODE_DOWN;
+       }
 }
 
 static int
@@ -334,7 +333,7 @@ lstcon_rpc_trans_check(lstcon_rpc_trans_t *trans)
             !cfs_list_empty(&trans->tas_olink)) /* Not an end session RPC */
                 return 1;
 
-        return (cfs_atomic_read(&trans->tas_remaining) == 0) ? 1: 0;
+       return (atomic_read(&trans->tas_remaining) == 0) ? 1: 0;
 }
 
 int
@@ -360,15 +359,15 @@ lstcon_rpc_trans_postwait(lstcon_rpc_trans_t *trans, int timeout)
                 lstcon_rpc_post(crpc);
         }
 
-        cfs_mutex_unlock(&console_session.ses_mutex);
+       mutex_unlock(&console_session.ses_mutex);
 
-        cfs_waitq_wait_event_interruptible_timeout(trans->tas_waitq,
-                                              lstcon_rpc_trans_check(trans),
-                                              cfs_time_seconds(timeout), rc);
+       rc = wait_event_interruptible_timeout(trans->tas_waitq,
+                                             lstcon_rpc_trans_check(trans),
+                                             cfs_time_seconds(timeout));
 
         rc = (rc > 0)? 0: ((rc < 0)? -EINTR: -ETIMEDOUT);
 
-        cfs_mutex_lock(&console_session.ses_mutex);
+       mutex_lock(&console_session.ses_mutex);
 
         if (console_session.ses_shutdown)
                 rc = -ESHUTDOWN;
@@ -495,7 +494,7 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
 
         cfs_list_for_each_entry_typed(crpc, &trans->tas_rpcs_list,
                                       lstcon_rpc_t, crp_link) {
-                if (cfs_copy_from_user(&tmp, next,
+               if (copy_from_user(&tmp, next,
                                        sizeof(cfs_list_t)))
                         return -EFAULT;
 
@@ -516,35 +515,36 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
                       (cfs_time_t)console_session.ses_id.ses_stamp);
                 cfs_duration_usec(dur, &tv);
 
-                if (cfs_copy_to_user(&ent->rpe_peer,
-                                     &nd->nd_id, sizeof(lnet_process_id_t)) ||
-                    cfs_copy_to_user(&ent->rpe_stamp, &tv, sizeof(tv)) ||
-                    cfs_copy_to_user(&ent->rpe_state,
-                                     &nd->nd_state, sizeof(nd->nd_state)) ||
-                    cfs_copy_to_user(&ent->rpe_rpc_errno, &error,
-                                     sizeof(error)))
-                        return -EFAULT;
-
-                if (error != 0)
-                        continue;
-
-                /* RPC is done */
-                rep = (srpc_generic_reply_t *)&msg->msg_body.reply;
-
-                if (cfs_copy_to_user(&ent->rpe_sid,
-                                     &rep->sid, sizeof(lst_sid_t)) ||
-                    cfs_copy_to_user(&ent->rpe_fwk_errno,
-                                     &rep->status, sizeof(rep->status)))
-                        return -EFAULT;
-
-                if (readent == NULL)
-                        continue;
-
-                if ((error = readent(trans->tas_opc, msg, ent)) != 0)
-                        return error;
-        }
+               if (copy_to_user(&ent->rpe_peer,
+                                &nd->nd_id, sizeof(lnet_process_id_t)) ||
+                   copy_to_user(&ent->rpe_stamp, &tv, sizeof(tv)) ||
+                   copy_to_user(&ent->rpe_state,
+                                &nd->nd_state, sizeof(nd->nd_state)) ||
+                   copy_to_user(&ent->rpe_rpc_errno, &error,
+                                    sizeof(error)))
+                       return -EFAULT;
+
+               if (error != 0)
+                       continue;
+
+               /* RPC is done */
+               rep = (srpc_generic_reply_t *)&msg->msg_body.reply;
+
+               if (copy_to_user(&ent->rpe_sid,
+                                &rep->sid, sizeof(lst_sid_t)) ||
+                   copy_to_user(&ent->rpe_fwk_errno,
+                                &rep->status, sizeof(rep->status)))
+                       return -EFAULT;
+
+               if (readent == NULL)
+                       continue;
+
+               error = readent(trans->tas_opc, msg, ent);
+               if (error != 0)
+                       return error;
+       }
 
-        return 0;
+       return 0;
 }
 
 void
@@ -560,11 +560,11 @@ lstcon_rpc_trans_destroy(lstcon_rpc_trans_t *trans)
                                            lstcon_rpc_t, crp_link) {
                 rpc = crpc->crp_rpc;
 
-                cfs_spin_lock(&rpc->crpc_lock);
+               spin_lock(&rpc->crpc_lock);
 
-                /* free it if not posted or finished already */
-                if (!crpc->crp_posted || crpc->crp_finished) {
-                        cfs_spin_unlock(&rpc->crpc_lock);
+               /* free it if not posted or finished already */
+               if (!crpc->crp_posted || crpc->crp_finished) {
+                       spin_unlock(&rpc->crpc_lock);
 
                         cfs_list_del_init(&crpc->crp_link);
                         lstcon_rpc_put(crpc);
@@ -584,12 +584,12 @@ lstcon_rpc_trans_destroy(lstcon_rpc_trans_t *trans)
                 cfs_list_del_init(&crpc->crp_link);
                 count ++;
 
-                cfs_spin_unlock(&rpc->crpc_lock);
+               spin_unlock(&rpc->crpc_lock);
 
-                cfs_atomic_dec(&trans->tas_remaining);
+               atomic_dec(&trans->tas_remaining);
         }
 
-        LASSERT (cfs_atomic_read(&trans->tas_remaining) == 0);
+       LASSERT (atomic_read(&trans->tas_remaining) == 0);
 
         cfs_list_del(&trans->tas_link);
         if (!cfs_list_empty(&trans->tas_olink))
@@ -721,7 +721,7 @@ lstcon_next_id(int idx, int nkiov, lnet_kiov_t *kiov)
         
         LASSERT (i < nkiov);
 
-        pid = (lnet_process_id_packed_t *)cfs_page_address(kiov[i].kiov_page);
+       pid = (lnet_process_id_packed_t *)page_address(kiov[i].kiov_page);
 
         return &pid[idx % SFW_ID_PER_PAGE];
 }
@@ -798,11 +798,12 @@ lstcon_bulkrpc_v0_prep(lst_test_bulk_param_t *param, srpc_test_reqst_t *req)
 {
        test_bulk_req_t *brq = &req->tsr_u.bulk_v0;
 
-        brq->blk_opc    = param->blk_opc;
-        brq->blk_npg    = (param->blk_size + CFS_PAGE_SIZE - 1) / CFS_PAGE_SIZE;
-        brq->blk_flags  = param->blk_flags;
+       brq->blk_opc    = param->blk_opc;
+       brq->blk_npg    = (param->blk_size + PAGE_CACHE_SIZE - 1) /
+                          PAGE_CACHE_SIZE;
+       brq->blk_flags  = param->blk_flags;
 
-        return 0;
+       return 0;
 }
 
 int
@@ -834,7 +835,7 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop, unsigned feats,
        if (transop == LST_TRANS_TSBCLIADD) {
                npg = sfw_id_pages(test->tes_span);
                nob = (feats & LST_FEAT_BULK_LEN) == 0 ?
-                     npg * CFS_PAGE_SIZE :
+                     npg * PAGE_CACHE_SIZE :
                      sizeof(lnet_process_id_packed_t) * test->tes_span;
        }
 
@@ -861,13 +862,13 @@ lstcon_testrpc_prep(lstcon_node_t *nd, int transop, unsigned feats,
                        LASSERT(nob > 0);
 
                        len = (feats & LST_FEAT_BULK_LEN) == 0 ?
-                             CFS_PAGE_SIZE : min_t(int, nob, CFS_PAGE_SIZE);
+                             PAGE_CACHE_SIZE : min_t(int, nob, PAGE_CACHE_SIZE);
                        nob -= len;
 
                        bulk->bk_iovs[i].kiov_offset = 0;
                        bulk->bk_iovs[i].kiov_len    = len;
                        bulk->bk_iovs[i].kiov_page   =
-                               cfs_alloc_page(CFS_ALLOC_STD);
+                               alloc_page(GFP_IOFS);
 
                        if (bulk->bk_iovs[i].kiov_page == NULL) {
                                lstcon_rpc_put(*crpc);
@@ -948,8 +949,12 @@ lstcon_sesnew_stat_reply(lstcon_rpc_trans_t *trans,
                return status;
 
        if (!trans->tas_feats_updated) {
-               trans->tas_feats_updated = 1;
-               trans->tas_features = reply->msg_ses_feats;
+               spin_lock(&console_session.ses_rpc_lock);
+               if (!trans->tas_feats_updated) { /* recheck with lock */
+                       trans->tas_feats_updated = 1;
+                       trans->tas_features = reply->msg_ses_feats;
+               }
+               spin_unlock(&console_session.ses_rpc_lock);
        }
 
        if (reply->msg_ses_feats != trans->tas_features) {
@@ -1190,10 +1195,10 @@ lstcon_rpc_pinger(void *arg)
         /* RPC pinger is a special case of transaction,
          * it's called by timer at 8 seconds interval.
          */
-        cfs_mutex_lock(&console_session.ses_mutex);
+       mutex_lock(&console_session.ses_mutex);
 
         if (console_session.ses_shutdown || console_session.ses_expired) {
-                cfs_mutex_unlock(&console_session.ses_mutex);
+               mutex_unlock(&console_session.ses_mutex);
                 return;
         }
 
@@ -1234,17 +1239,17 @@ lstcon_rpc_pinger(void *arg)
                         LASSERT (crpc->crp_trans == trans);
                         LASSERT (!cfs_list_empty(&crpc->crp_link));
 
-                        cfs_spin_lock(&crpc->crp_rpc->crpc_lock);
+                       spin_lock(&crpc->crp_rpc->crpc_lock);
 
-                        LASSERT (crpc->crp_posted);
+                       LASSERT(crpc->crp_posted);
 
-                        if (!crpc->crp_finished) {
-                                /* in flight */
-                                cfs_spin_unlock(&crpc->crp_rpc->crpc_lock);
-                                continue;
-                        }
+                       if (!crpc->crp_finished) {
+                               /* in flight */
+                               spin_unlock(&crpc->crp_rpc->crpc_lock);
+                               continue;
+                       }
 
-                        cfs_spin_unlock(&crpc->crp_rpc->crpc_lock);
+                       spin_unlock(&crpc->crp_rpc->crpc_lock);
 
                         lstcon_rpc_get_reply(crpc, &rep);
 
@@ -1280,7 +1285,7 @@ lstcon_rpc_pinger(void *arg)
         }
 
         if (console_session.ses_expired) {
-                cfs_mutex_unlock(&console_session.ses_mutex);
+               mutex_unlock(&console_session.ses_mutex);
                 return;
         }
 
@@ -1289,7 +1294,7 @@ lstcon_rpc_pinger(void *arg)
         ptimer->stt_expires = (cfs_time_t)(cfs_time_current_sec() + LST_PING_INTERVAL);
         stt_add_timer(ptimer);
 
-        cfs_mutex_unlock(&console_session.ses_mutex);
+       mutex_unlock(&console_session.ses_mutex);
 }
 
 int
@@ -1299,7 +1304,7 @@ lstcon_rpc_pinger_start(void)
         int             rc;
 
         LASSERT (cfs_list_empty(&console_session.ses_rpc_freelist));
-        LASSERT (cfs_atomic_read(&console_session.ses_rpc_counter) == 0);
+       LASSERT (atomic_read(&console_session.ses_rpc_counter) == 0);
 
         rc = lstcon_rpc_trans_prep(NULL, LST_TRANS_SESPING,
                                    &console_session.ses_ping);
@@ -1349,33 +1354,33 @@ lstcon_rpc_cleanup_wait(void)
                         trans = cfs_list_entry(pacer, lstcon_rpc_trans_t,
                                                tas_link);
 
-                        CDEBUG(D_NET, "Session closed, wakeup transaction %s\n",
-                               lstcon_rpc_trans_name(trans->tas_opc));
+                       CDEBUG(D_NET, "Session closed, wakeup transaction %s\n",
+                              lstcon_rpc_trans_name(trans->tas_opc));
 
-                        cfs_waitq_signal(&trans->tas_waitq);
-                }
+                       wake_up(&trans->tas_waitq);
+               }
 
-                cfs_mutex_unlock(&console_session.ses_mutex);
+               mutex_unlock(&console_session.ses_mutex);
 
-                CWARN("Session is shutting down, "
-                      "waiting for termination of transactions\n");
-                cfs_pause(cfs_time_seconds(1));
+               CWARN("Session is shutting down, "
+                     "waiting for termination of transactions\n");
+               cfs_pause(cfs_time_seconds(1));
 
-                cfs_mutex_lock(&console_session.ses_mutex);
+               mutex_lock(&console_session.ses_mutex);
         }
 
-        cfs_spin_lock(&console_session.ses_rpc_lock);
+       spin_lock(&console_session.ses_rpc_lock);
 
-        lst_wait_until((cfs_atomic_read(&console_session.ses_rpc_counter) == 0),
+       lst_wait_until((atomic_read(&console_session.ses_rpc_counter) == 0),
                        console_session.ses_rpc_lock,
                        "Network is not accessable or target is down, "
                        "waiting for %d console RPCs to being recycled\n",
-                       cfs_atomic_read(&console_session.ses_rpc_counter));
+                      atomic_read(&console_session.ses_rpc_counter));
 
         cfs_list_add(&zlist, &console_session.ses_rpc_freelist);
         cfs_list_del_init(&console_session.ses_rpc_freelist);
 
-        cfs_spin_unlock(&console_session.ses_rpc_lock);
+       spin_unlock(&console_session.ses_rpc_lock);
 
         while (!cfs_list_empty(&zlist)) {
                 crpc = cfs_list_entry(zlist.next, lstcon_rpc_t, crp_link);
@@ -1394,18 +1399,18 @@ lstcon_rpc_module_init(void)
 
         console_session.ses_ping = NULL;
 
-        cfs_spin_lock_init(&console_session.ses_rpc_lock);
-        cfs_atomic_set(&console_session.ses_rpc_counter, 0);
-        CFS_INIT_LIST_HEAD(&console_session.ses_rpc_freelist);
+       spin_lock_init(&console_session.ses_rpc_lock);
+       atomic_set(&console_session.ses_rpc_counter, 0);
+       CFS_INIT_LIST_HEAD(&console_session.ses_rpc_freelist);
 
-        return 0;
+       return 0;
 }
 
 void
 lstcon_rpc_module_fini(void)
 {
         LASSERT (cfs_list_empty(&console_session.ses_rpc_freelist));
-        LASSERT (cfs_atomic_read(&console_session.ses_rpc_counter) == 0);
+       LASSERT (atomic_read(&console_session.ses_rpc_counter) == 0);
 }
 
 #endif