Whamcloud - gitweb
LU-12094 ptlrpc: protect obd_import in lprocfs_import_seq_write
[fs/lustre-release.git] / libcfs / libcfs / util / nidstrings.c
index 26c4fec..246d420 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -27,7 +23,7 @@
  * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2014, Intel Corporation.
+ * Copyright (c) 2011, 2017, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
 
 #define DEBUG_SUBSYSTEM S_LNET
 
+#include <assert.h>
+#include <errno.h>
+#include <stdio.h>
+#include <stdbool.h>
+#include <stdlib.h>
+#include <string.h>
+
 #include <libcfs/util/string.h>
-#include <libcfs/libcfs.h>
-#include <lnet/nidstr.h>
-#ifdef HAVE_GETHOSTBYNAME
+#include <linux/lnet/lnet-types.h>
+#include <linux/lnet/nidstr.h>
+#ifdef HAVE_NETDB_H
 # include <netdb.h>
 #endif
 
@@ -80,187 +83,6 @@ libcfs_next_nidstring(void)
        return str;
 }
 
-static int  libcfs_lo_str2addr(const char *str, int nob, __u32 *addr);
-static void libcfs_ip_addr2str(__u32 addr, char *str, size_t size);
-static int  libcfs_ip_str2addr(const char *str, int nob, __u32 *addr);
-static bool cfs_ip_is_contiguous(struct list_head *nidlist);
-static void cfs_ip_min_max(struct list_head *nidlist, __u32 *min, __u32 *max);
-static void libcfs_decnum_addr2str(__u32 addr, char *str, size_t size);
-static void libcfs_hexnum_addr2str(__u32 addr, char *str, size_t size);
-static int  libcfs_num_str2addr(const char *str, int nob, __u32 *addr);
-static int  libcfs_num_parse(char *str, int len, struct list_head *list);
-static int  libcfs_num_match(__u32 addr, struct list_head *list);
-static int  libcfs_num_addr_range_print(char *buffer, int count,
-                                       struct list_head *list);
-static int  libcfs_ip_addr_range_print(char *buffer, int count,
-                                      struct list_head *list);
-static bool cfs_num_is_contiguous(struct list_head *nidlist);
-static void cfs_num_min_max(struct list_head *nidlist, __u32 *min, __u32 *max);
-
-struct netstrfns {
-       __u32 nf_type;
-       char    *nf_name;
-       char    *nf_modname;
-       void    (*nf_addr2str)(__u32 addr, char *str, size_t size);
-       int     (*nf_str2addr)(const char *str, int nob, __u32 *addr);
-       int     (*nf_parse_addrlist)(char *str, int len,
-                                       struct list_head *list);
-       int     (*nf_print_addrlist)(char *buffer, int count,
-                                    struct list_head *list);
-       int     (*nf_match_addr)(__u32 addr, struct list_head *list);
-       bool    (*nf_is_contiguous)(struct list_head *nidlist);
-       void    (*nf_min_max)(struct list_head *nidlist, __u32 *min_nid,
-                             __u32 *max_nid);
-};
-
-static struct netstrfns  libcfs_netstrfns[] = {
-       {/* .nf_type      */  LOLND,
-        /* .nf_name      */  "lo",
-        /* .nf_modname   */  "klolnd",
-        /* .nf_addr2str  */  libcfs_decnum_addr2str,
-        /* .nf_str2addr  */  libcfs_lo_str2addr,
-        /* .nf_parse_addr*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */  SOCKLND,
-        /* .nf_name      */  "tcp",
-        /* .nf_modname   */  "ksocklnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  O2IBLND,
-        /* .nf_name      */  "o2ib",
-        /* .nf_modname   */  "ko2iblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  CIBLND,
-        /* .nf_name      */  "cib",
-        /* .nf_modname   */  "kciblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  OPENIBLND,
-        /* .nf_name      */  "openib",
-        /* .nf_modname   */  "kopeniblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  IIBLND,
-        /* .nf_name      */  "iib",
-        /* .nf_modname   */  "kiiblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  VIBLND,
-        /* .nf_name      */  "vib",
-        /* .nf_modname   */  "kviblnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */  RALND,
-        /* .nf_name      */  "ra",
-        /* .nf_modname   */  "kralnd",
-        /* .nf_addr2str  */  libcfs_ip_addr2str,
-        /* .nf_str2addr  */  libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */      QSWLND,
-        /* .nf_name      */      "elan",
-        /* .nf_modname   */      "kqswlnd",
-        /* .nf_addr2str  */      libcfs_decnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      GMLND,
-        /* .nf_name      */      "gm",
-        /* .nf_modname   */      "kgmlnd",
-        /* .nf_addr2str  */      libcfs_hexnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      MXLND,
-        /* .nf_name      */      "mx",
-        /* .nf_modname   */      "kmxlnd",
-        /* .nf_addr2str  */      libcfs_ip_addr2str,
-        /* .nf_str2addr  */      libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-       {/* .nf_type      */      PTLLND,
-        /* .nf_name      */      "ptl",
-        /* .nf_modname   */      "kptllnd",
-        /* .nf_addr2str  */      libcfs_decnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      GNILND,
-        /* .nf_name      */      "gni",
-        /* .nf_modname   */      "kgnilnd",
-        /* .nf_addr2str  */      libcfs_decnum_addr2str,
-        /* .nf_str2addr  */      libcfs_num_str2addr,
-        /* .nf_parse_addrlist*/  libcfs_num_parse,
-        /* .nf_print_addrlist*/  libcfs_num_addr_range_print,
-        /* .nf_match_addr*/      libcfs_num_match,
-        /* .nf_is_contiguous */  cfs_num_is_contiguous,
-        /* .nf_min_max   */      cfs_num_min_max},
-       {/* .nf_type      */      GNIIPLND,
-        /* .nf_name      */      "gip",
-        /* .nf_modname   */      "kgnilnd",
-        /* .nf_addr2str  */      libcfs_ip_addr2str,
-        /* .nf_str2addr  */      libcfs_ip_str2addr,
-        /* .nf_parse_addrlist*/  cfs_ip_addr_parse,
-        /* .nf_print_addrlist*/  libcfs_ip_addr_range_print,
-        /* .nf_match_addr*/      cfs_ip_addr_match,
-        /* .nf_is_contiguous */  cfs_ip_is_contiguous,
-        /* .nf_min_max   */      cfs_ip_min_max},
-        /* placeholder for net0 alias.  It MUST BE THE LAST ENTRY */
-       {/* .nf_type      */  -1},
-};
-
-static const size_t libcfs_nnetstrfns =
-       sizeof(libcfs_netstrfns)/sizeof(libcfs_netstrfns[0]);
-
 static int
 libcfs_lo_str2addr(const char *str, int nob, __u32 *addr)
 {
@@ -329,16 +151,159 @@ libcfs_ip_str2addr(const char *str, int nob, __u32 *addr)
        return 0;
 }
 
-static void
-libcfs_decnum_addr2str(__u32 addr, char *str, size_t size)
+int
+cfs_ip_addr_parse(char *str, int len, struct list_head *list)
 {
-       snprintf(str, size, "%u", addr);
+       struct cfs_expr_list *el;
+       struct cfs_lstr src;
+       int rc;
+       int i;
+
+       src.ls_str = str;
+       src.ls_len = len;
+       i = 0;
+
+       while (src.ls_str != NULL) {
+               struct cfs_lstr res;
+
+               if (!cfs_gettok(&src, '.', &res)) {
+                       rc = -EINVAL;
+                       goto out;
+               }
+
+               rc = cfs_expr_list_parse(res.ls_str, res.ls_len, 0, 255, &el);
+               if (rc != 0)
+                       goto out;
+
+               list_add_tail(&el->el_link, list);
+               i++;
+       }
+
+       if (i == 4)
+               return 0;
+
+       rc = -EINVAL;
+out:
+       cfs_expr_list_free_list(list);
+
+       return rc;
+}
+
+static int
+libcfs_ip_addr_range_print(char *buffer, int count, struct list_head *list)
+{
+       int i = 0, j = 0;
+       struct cfs_expr_list *el;
+
+       list_for_each_entry(el, list, el_link) {
+               assert(j++ < 4);
+               if (i != 0)
+                       i += snprintf(buffer + i, count - i, ".");
+               i += cfs_expr_list_print(buffer + i, count - i, el);
+       }
+       return i;
+}
+
+static int
+cfs_ip_addr_range_gen_recurse(__u32 *ip_list, int *count, int shift,
+                             __u32 result, struct list_head *head_el,
+                             struct cfs_expr_list *octet_el)
+{
+       __u32 value = 0;
+       int i;
+       struct cfs_expr_list *next_octet_el;
+       struct cfs_range_expr *octet_expr;
+
+       /*
+        * each octet can have multiple expressions so we need to traverse
+        * all of the expressions
+        */
+       list_for_each_entry(octet_expr, &octet_el->el_exprs, re_link) {
+               for (i = octet_expr->re_lo; i <= octet_expr->re_hi; i++) {
+                       if (((i - octet_expr->re_lo) % octet_expr->re_stride) == 0) {
+                               /*
+                                * we have a hit calculate the result and
+                                * pass it forward to the next iteration
+                                * of the recursion.
+                                */
+                               next_octet_el =
+                                       list_entry(octet_el->el_link.next,
+                                                       typeof(*next_octet_el),
+                                                       el_link);
+                               value = result | (i << (shift * 8));
+                               if (next_octet_el->el_link.next != head_el) {
+                                       /*
+                                        * We still have more octets in
+                                        * the IP address so traverse
+                                        * that. We're doing a depth first
+                                        * recursion here.
+                                        */
+                                       if (cfs_ip_addr_range_gen_recurse(ip_list, count,
+                                                                         shift - 1, value,
+                                                                         head_el,
+                                                                         next_octet_el) == -1)
+                                               return -1;
+                               } else {
+                                       /*
+                                        * We have hit a leaf so store the
+                                        * calculated IP address in the
+                                        * list. If we have run out of
+                                        * space stop the recursion.
+                                        */
+                                       if (*count == -1)
+                                               return -1;
+                                       /* add ip to the list */
+                                       ip_list[*count] = value;
+                                       (*count)--;
+                               }
+                       }
+               }
+       }
+       return 0;
+}
+
+/*
+ * only generate maximum of count ip addresses from the given expression
+ */
+int
+cfs_ip_addr_range_gen(__u32 *ip_list, int count, struct list_head *ip_addr_expr)
+{
+       struct cfs_expr_list *octet_el;
+       int idx = count - 1;
+
+       octet_el = list_entry(ip_addr_expr->next, typeof(*octet_el), el_link);
+
+       (void) cfs_ip_addr_range_gen_recurse(ip_list, &idx, 3, 0, &octet_el->el_link, octet_el);
+
+       return idx;
+}
+
+/**
+ * Matches address (\a addr) against address set encoded in \a list.
+ *
+ * \retval 1 if \a addr matches
+ * \retval 0 otherwise
+ */
+int
+cfs_ip_addr_match(__u32 addr, struct list_head *list)
+{
+       struct cfs_expr_list *el;
+       int i = 0;
+
+       list_for_each_entry_reverse(el, list, el_link) {
+               if (!cfs_expr_list_match(addr & 0xff, el))
+                       return 0;
+               addr >>= 8;
+               i++;
+       }
+
+       return i == 4;
 }
 
 static void
-libcfs_hexnum_addr2str(__u32 addr, char *str, size_t size)
+libcfs_decnum_addr2str(__u32 addr, char *str, size_t size)
 {
-       snprintf(str, size, "0x%x", addr);
+       snprintf(str, size, "%u", addr);
 }
 
 static int
@@ -361,6 +326,132 @@ libcfs_num_str2addr(const char *str, int nob, __u32 *addr)
        return 0;
 }
 
+/**
+ * Nf_parse_addrlist method for networks using numeric addresses.
+ *
+ * Examples of such networks are gm and elan.
+ *
+ * \retval 0 if \a str parsed to numeric address
+ * \retval errno otherwise
+ */
+static int
+libcfs_num_parse(char *str, int len, struct list_head *list)
+{
+       struct cfs_expr_list *el;
+       int     rc;
+
+       rc = cfs_expr_list_parse(str, len, 0, MAX_NUMERIC_VALUE, &el);
+       if (rc == 0)
+               list_add_tail(&el->el_link, list);
+
+       return rc;
+}
+
+static int
+libcfs_num_addr_range_print(char *buffer, int count, struct list_head *list)
+{
+       struct cfs_expr_list *el;
+       int i = 0, j = 0;
+
+       list_for_each_entry(el, list, el_link) {
+               assert(j++ < 1);
+               i += cfs_expr_list_print(buffer + i, count - i, el);
+       }
+       return i;
+}
+
+/*
+ * Nf_match_addr method for networks using numeric addresses
+ *
+ * \retval 1 on match
+ * \retval 0 otherwise
+ */
+static int
+libcfs_num_match(__u32 addr, struct list_head *numaddr)
+{
+       struct cfs_expr_list *el;
+
+       assert(!list_empty(numaddr));
+       el = list_entry(numaddr->next, struct cfs_expr_list, el_link);
+
+       return cfs_expr_list_match(addr, el);
+}
+
+static int cfs_ip_min_max(struct list_head *nidlist, __u32 *min, __u32 *max);
+static int cfs_num_min_max(struct list_head *nidlist, __u32 *min, __u32 *max);
+
+static struct netstrfns libcfs_netstrfns[] = {
+       {
+               .nf_type                = LOLND,
+               .nf_name                = "lo",
+               .nf_modname             = "klolnd",
+               .nf_addr2str            = libcfs_decnum_addr2str,
+               .nf_str2addr            = libcfs_lo_str2addr,
+               .nf_parse_addrlist      = libcfs_num_parse,
+               .nf_print_addrlist      = libcfs_num_addr_range_print,
+               .nf_match_addr          = libcfs_num_match,
+               .nf_min_max             = cfs_num_min_max
+       },
+       {
+               .nf_type                = SOCKLND,
+               .nf_name                = "tcp",
+               .nf_modname             = "ksocklnd",
+               .nf_addr2str            = libcfs_ip_addr2str,
+               .nf_str2addr            = libcfs_ip_str2addr,
+               .nf_parse_addrlist      = cfs_ip_addr_parse,
+               .nf_print_addrlist      = libcfs_ip_addr_range_print,
+               .nf_match_addr          = cfs_ip_addr_match,
+               .nf_min_max             = cfs_ip_min_max
+       },
+       {
+               .nf_type                = O2IBLND,
+               .nf_name                = "o2ib",
+               .nf_modname             = "ko2iblnd",
+               .nf_addr2str            = libcfs_ip_addr2str,
+               .nf_str2addr            = libcfs_ip_str2addr,
+               .nf_parse_addrlist      = cfs_ip_addr_parse,
+               .nf_print_addrlist      = libcfs_ip_addr_range_print,
+               .nf_match_addr          = cfs_ip_addr_match,
+               .nf_min_max             = cfs_ip_min_max
+       },
+       {
+               .nf_type                = GNILND,
+               .nf_name                = "gni",
+               .nf_modname             = "kgnilnd",
+               .nf_addr2str            = libcfs_decnum_addr2str,
+               .nf_str2addr            = libcfs_num_str2addr,
+               .nf_parse_addrlist      = libcfs_num_parse,
+               .nf_print_addrlist      = libcfs_num_addr_range_print,
+               .nf_match_addr          = libcfs_num_match,
+               .nf_min_max             = cfs_num_min_max
+       },
+       {
+               .nf_type                = GNIIPLND,
+               .nf_name                = "gip",
+               .nf_modname             = "kgnilnd",
+               .nf_addr2str            = libcfs_ip_addr2str,
+               .nf_str2addr            = libcfs_ip_str2addr,
+               .nf_parse_addrlist      = cfs_ip_addr_parse,
+               .nf_print_addrlist      = libcfs_ip_addr_range_print,
+               .nf_match_addr          = cfs_ip_addr_match,
+               .nf_min_max             = cfs_ip_min_max
+       },
+       {
+               .nf_type                = PTL4LND,
+               .nf_name                = "ptlf",
+               .nf_modname             = "kptl4lnd",
+               .nf_addr2str            = libcfs_decnum_addr2str,
+               .nf_str2addr            = libcfs_num_str2addr,
+               .nf_parse_addrlist      = libcfs_num_parse,
+               .nf_print_addrlist      = libcfs_num_addr_range_print,
+               .nf_match_addr          = libcfs_num_match,
+               .nf_min_max             = cfs_num_min_max
+       }
+};
+
+static const size_t libcfs_nnetstrfns =
+       sizeof(libcfs_netstrfns)/sizeof(libcfs_netstrfns[0]);
+
 static struct netstrfns *
 libcfs_lnd2netstrfns(__u32 lnd)
 {
@@ -381,8 +472,7 @@ libcfs_namenum2netstrfns(const char *name)
 
        for (i = 0; i < libcfs_nnetstrfns; i++) {
                nf = &libcfs_netstrfns[i];
-               if (nf->nf_type >= 0 &&
-                   !strncmp(name, nf->nf_name, strlen(nf->nf_name)))
+               if (!strncmp(name, nf->nf_name, strlen(nf->nf_name)))
                        return nf;
        }
        return NULL;
@@ -394,8 +484,7 @@ libcfs_name2netstrfns(const char *name)
        int    i;
 
        for (i = 0; i < libcfs_nnetstrfns; i++)
-               if (libcfs_netstrfns[i].nf_type >= 0 &&
-                   !strcmp(libcfs_netstrfns[i].nf_name, name))
+               if (!strcmp(libcfs_netstrfns[i].nf_name, name))
                        return &libcfs_netstrfns[i];
 
        return NULL;
@@ -502,8 +591,7 @@ libcfs_str2net_internal(const char *str, __u32 *net)
 
        for (i = 0; i < libcfs_nnetstrfns; i++) {
                nf = &libcfs_netstrfns[i];
-               if (nf->nf_type >= 0 &&
-                   !strncmp(str, nf->nf_name, strlen(nf->nf_name)))
+               if (!strncmp(str, nf->nf_name, strlen(nf->nf_name)))
                        break;
        }
 
@@ -556,7 +644,7 @@ libcfs_str2nid(const char *str)
                sep = str + strlen(str);
                net = LNET_MKNET(SOCKLND, 0);
                nf = libcfs_lnd2netstrfns(SOCKLND);
-               LASSERT(nf != NULL);
+               assert(nf != NULL);
        }
 
        if (!nf->nf_str2addr(str, (int)(sep - str), &addr))
@@ -566,7 +654,7 @@ libcfs_str2nid(const char *str)
 }
 
 char *
-libcfs_id2str(lnet_process_id_t id)
+libcfs_id2str(struct lnet_process_id id)
 {
        char *str = libcfs_next_nidstring();
 
@@ -661,27 +749,6 @@ struct addrrange {
 };
 
 /**
- * Nf_parse_addrlist method for networks using numeric addresses.
- *
- * Examples of such networks are gm and elan.
- *
- * \retval 0 if \a str parsed to numeric address
- * \retval errno otherwise
- */
-static int
-libcfs_num_parse(char *str, int len, struct list_head *list)
-{
-       struct cfs_expr_list *el;
-       int     rc;
-
-       rc = cfs_expr_list_parse(str, len, 0, MAX_NUMERIC_VALUE, &el);
-       if (rc == 0)
-               list_add_tail(&el->el_link, list);
-
-       return rc;
-}
-
-/**
  * Parses \<addrrange\> token on the syntax.
  *
  * Allocates struct addrrange and links to \a nidrange via
@@ -799,7 +866,8 @@ parse_nidrange(struct cfs_lstr *src, struct list_head *nidlist)
 
        return 1;
  failed:
-       CWARN("can't parse nidrange: \"%.*s\"\n", tmp.ls_len, tmp.ls_str);
+       fprintf(stderr, "can't parse nidrange: \"%.*s\"\n",
+               tmp.ls_len, tmp.ls_str);
        return 0;
 }
 
@@ -885,23 +953,6 @@ cfs_parse_nidlist(char *str, int len, struct list_head *nidlist)
        return 1;
 }
 
-/*
- * Nf_match_addr method for networks using numeric addresses
- *
- * \retval 1 on match
- * \retval 0 otherwise
- */
-static int
-libcfs_num_match(__u32 addr, struct list_head *numaddr)
-{
-       struct cfs_expr_list *el;
-
-       LASSERT(!list_empty(numaddr));
-       el = list_entry(numaddr->next, struct cfs_expr_list, el_link);
-
-       return cfs_expr_list_match(addr, el);
-}
-
 /**
  * Matches a nid (\a nid) against the compiled list of nidranges (\a nidlist).
  *
@@ -930,35 +981,6 @@ int cfs_match_nid(lnet_nid_t nid, struct list_head *nidlist)
        return 0;
 }
 
-static int
-libcfs_num_addr_range_print(char *buffer, int count, struct list_head *list)
-{
-       int i = 0, j = 0;
-       struct cfs_expr_list *el;
-
-       list_for_each_entry(el, list, el_link) {
-               LASSERT(j++ < 1);
-               i += cfs_expr_list_print(buffer + i, count - i, el);
-       }
-       return i;
-}
-
-static int
-libcfs_ip_addr_range_print(char *buffer, int count, struct list_head *list)
-{
-       int i = 0, j = 0;
-       struct cfs_expr_list *el;
-
-       list_for_each_entry(el, list, el_link) {
-               LASSERT(j++ < 4);
-               if (i != 0)
-                       i += snprintf(buffer + i, count - i, ".");
-               i += cfs_expr_list_print(buffer + i, count - i, el);
-       }
-       return i;
-}
-
-
 /**
  * Print the network part of the nidrange \a nr into the specified \a buffer.
  *
@@ -1021,7 +1043,7 @@ int cfs_print_nidlist(char *buffer, int count, struct list_head *nidlist)
                        i += snprintf(buffer + i, count - i, " ");
 
                if (nr->nr_all != 0) {
-                       LASSERT(list_empty(&nr->nr_addrranges));
+                       assert(list_empty(&nr->nr_addrranges));
                        i += snprintf(buffer + i, count - i, "*");
                        i += cfs_print_network(buffer + i, count - i, nr);
                } else {
@@ -1037,38 +1059,62 @@ int cfs_print_nidlist(char *buffer, int count, struct list_head *nidlist)
  * numeric address range
  *
  * \param      ar
- * \param      min_nid
- * \param      max_nid
+ * \param[out] *min_nid __u32 representation of min NID
+ * \param[out] *max_nid __u32 representation of max NID
+ * \retval     -EINVAL unsupported LNET range
+ * \retval     -ERANGE non-contiguous LNET range
  */
-static void cfs_ip_ar_min_max(struct addrrange *ar, __u32 *min_nid,
+static int cfs_ip_ar_min_max(struct addrrange *ar, __u32 *min_nid,
                              __u32 *max_nid)
 {
-       struct cfs_expr_list    *el;
-       struct cfs_range_expr   *re;
-       __u32                   tmp_ip_addr = 0;
-       unsigned int            min_ip[4] = {0};
-       unsigned int            max_ip[4] = {0};
-       int                     re_count = 0;
+       struct cfs_expr_list *expr_list;
+       struct cfs_range_expr *range;
+       unsigned int min_ip[4] = {0};
+       unsigned int max_ip[4] = {0};
+       int cur_octet = 0;
+       bool expect_full_octet = false;
+
+       list_for_each_entry(expr_list, &ar->ar_numaddr_ranges, el_link) {
+               int re_count = 0;
+
+               list_for_each_entry(range, &expr_list->el_exprs, re_link) {
+                       /* XXX: add support for multiple & non-contig. re's */
+                       if (re_count > 0)
+                               return -EINVAL;
+
+                       /* if a previous octet was ranged, then all remaining
+                        * octets must be full for contiguous range */
+                       if (expect_full_octet && (range->re_lo != 0 ||
+                                                 range->re_hi != 255))
+                               return -ERANGE;
+
+                       if (range->re_stride != 1)
+                               return -ERANGE;
+
+                       if (range->re_lo > range->re_hi)
+                               return -EINVAL;
+
+                       if (range->re_lo != range->re_hi)
+                               expect_full_octet = true;
+
+                       min_ip[cur_octet] = range->re_lo;
+                       max_ip[cur_octet] = range->re_hi;
 
-       list_for_each_entry(el, &ar->ar_numaddr_ranges, el_link) {
-               list_for_each_entry(re, &el->el_exprs, re_link) {
-                       min_ip[re_count] = re->re_lo;
-                       max_ip[re_count] = re->re_hi;
                        re_count++;
                }
-       }
 
-       tmp_ip_addr = ((min_ip[0] << 24) | (min_ip[1] << 16) |
-                      (min_ip[2] << 8) | min_ip[3]);
+               cur_octet++;
+       }
 
        if (min_nid != NULL)
-               *min_nid = tmp_ip_addr;
-
-       tmp_ip_addr = ((max_ip[0] << 24) | (max_ip[1] << 16) |
-                      (max_ip[2] << 8) | max_ip[3]);
+               *min_nid = ((min_ip[0] << 24) | (min_ip[1] << 16) |
+                           (min_ip[2] << 8) | min_ip[3]);
 
        if (max_nid != NULL)
-               *max_nid = tmp_ip_addr;
+               *max_nid = ((max_ip[0] << 24) | (max_ip[1] << 16) |
+                           (max_ip[2] << 8) | max_ip[3]);
+
+       return 0;
 }
 
 /**
@@ -1076,23 +1122,33 @@ static void cfs_ip_ar_min_max(struct addrrange *ar, __u32 *min_nid,
  * numeric address range
  *
  * \param      ar
- * \param      min_nid
- * \param      max_nid
+ * \param[out] *min_nid __u32 representation of min NID
+ * \param[out] *max_nid __u32 representation of max NID
+ * \retval     -EINVAL unsupported LNET range
  */
-static void cfs_num_ar_min_max(struct addrrange *ar, __u32 *min_nid,
+static int cfs_num_ar_min_max(struct addrrange *ar, __u32 *min_nid,
                               __u32 *max_nid)
 {
-       struct cfs_expr_list    *el;
-       struct cfs_range_expr   *re;
-       unsigned int            min_addr = 0;
-       unsigned int            max_addr = 0;
+       struct cfs_expr_list *el;
+       struct cfs_range_expr *re;
+       unsigned int min_addr = 0;
+       unsigned int max_addr = 0;
 
        list_for_each_entry(el, &ar->ar_numaddr_ranges, el_link) {
+               int re_count = 0;
+
                list_for_each_entry(re, &el->el_exprs, re_link) {
+                       if (re_count > 0)
+                               return -EINVAL;
+                       if (re->re_lo > re->re_hi)
+                               return -EINVAL;
+
                        if (re->re_lo < min_addr || min_addr == 0)
                                min_addr = re->re_lo;
                        if (re->re_hi > max_addr)
                                max_addr = re->re_hi;
+
+                       re_count++;
                }
        }
 
@@ -1100,143 +1156,8 @@ static void cfs_num_ar_min_max(struct addrrange *ar, __u32 *min_nid,
                *min_nid = min_addr;
        if (max_nid != NULL)
                *max_nid = max_addr;
-}
-
-/**
- * Determines whether an expression list in an nidrange contains exactly
- * one contiguous address range. Calls the correct netstrfns for the LND
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-bool cfs_nidrange_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange         *nr;
-       struct netstrfns        *nf = NULL;
-       char                    *lndname = NULL;
-       int                     netnum = -1;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               nf = nr->nr_netstrfns;
-               if (lndname == NULL)
-                       lndname = nf->nf_name;
-               if (netnum == -1)
-                       netnum = nr->nr_netnum;
-
-               if (strcmp(lndname, nf->nf_name) != 0 ||
-                   netnum != nr->nr_netnum)
-                       return false;
-       }
-
-       if (nf == NULL)
-               return false;
-
-       if (!nf->nf_is_contiguous(nidlist))
-               return false;
-
-       return true;
-}
-
-/**
- * Determines whether an expression list in an num nidrange contains exactly
- * one contiguous address range.
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-static bool cfs_num_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange         *nr;
-       struct addrrange        *ar;
-       struct cfs_expr_list    *el;
-       struct cfs_range_expr   *re;
-       int                     last_hi = 0;
-       __u32                   last_end_nid = 0;
-       __u32                   current_start_nid = 0;
-       __u32                   current_end_nid = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_num_ar_min_max(ar, &current_start_nid,
-                                          &current_end_nid);
-                       if (last_end_nid != 0 &&
-                           (current_start_nid - last_end_nid != 1))
-                                       return false;
-                       last_end_nid = current_end_nid;
-                       list_for_each_entry(el, &ar->ar_numaddr_ranges,
-                                           el_link) {
-                               list_for_each_entry(re, &el->el_exprs,
-                                                   re_link) {
-                                       if (re->re_stride > 1)
-                                               return false;
-                                       else if (last_hi != 0 &&
-                                                re->re_hi - last_hi != 1)
-                                               return false;
-                                       last_hi = re->re_hi;
-                               }
-                       }
-               }
-       }
 
-       return true;
-}
-
-/**
- * Determines whether an expression list in an ip nidrange contains exactly
- * one contiguous address range.
- *
- * \param      *nidlist
- *
- * \retval     true if contiguous
- * \retval     false if not contiguous
- */
-static bool cfs_ip_is_contiguous(struct list_head *nidlist)
-{
-       struct nidrange         *nr;
-       struct addrrange        *ar;
-       struct cfs_expr_list    *el;
-       struct cfs_range_expr   *re;
-       int                     expr_count;
-       int                     last_hi = 255;
-       int                     last_diff = 0;
-       __u32                   last_end_nid = 0;
-       __u32                   current_start_nid = 0;
-       __u32                   current_end_nid = 0;
-
-       list_for_each_entry(nr, nidlist, nr_link) {
-               list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       last_hi = 255;
-                       last_diff = 0;
-                       cfs_ip_ar_min_max(ar, &current_start_nid,
-                                         &current_end_nid);
-                       if (last_end_nid != 0 &&
-                           (current_start_nid - last_end_nid != 1))
-                                       return false;
-                       last_end_nid = current_end_nid;
-                       list_for_each_entry(el,
-                                           &ar->ar_numaddr_ranges,
-                                           el_link) {
-                               expr_count = 0;
-                               list_for_each_entry(re, &el->el_exprs,
-                                                   re_link) {
-                                       expr_count++;
-                                       if (re->re_stride > 1 ||
-                                           (last_diff > 0 && last_hi != 255) ||
-                                           (last_diff > 0 && last_hi == 255 &&
-                                            re->re_lo > 0))
-                                               return false;
-                                       last_hi = re->re_hi;
-                                       last_diff = re->re_hi - re->re_lo;
-                               }
-                       }
-               }
-       }
-
-       return true;
+       return 0;
 }
 
 /**
@@ -1244,29 +1165,34 @@ static bool cfs_ip_is_contiguous(struct list_head *nidlist)
  * and maximum nid and creates appropriate nid structures
  *
  * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
+ * \param[out] *min_nid string representation of min NID
+ * \param[out] *max_nid string representation of max NID
+ * \retval     -EINVAL unsupported LNET range
+ * \retval     -ERANGE non-contiguous LNET range
  */
-void cfs_nidrange_find_min_max(struct list_head *nidlist, char *min_nid,
-                              char *max_nid, size_t nidstr_length)
+int cfs_nidrange_find_min_max(struct list_head *nidlist, char *min_nid,
+                             char *max_nid, size_t nidstr_length)
 {
-       struct nidrange         *nr;
-       struct netstrfns        *nf = NULL;
-       int                     netnum = -1;
-       __u32                   min_addr;
-       __u32                   max_addr;
-       char                    *lndname = NULL;
-       char                    min_addr_str[IPSTRING_LENGTH];
-       char                    max_addr_str[IPSTRING_LENGTH];
+       struct nidrange *first_nidrange;
+       int netnum;
+       struct netstrfns *nf;
+       char *lndname;
+       __u32 min_addr;
+       __u32 max_addr;
+       char min_addr_str[IPSTRING_LENGTH];
+       char max_addr_str[IPSTRING_LENGTH];
+       int rc;
 
-       list_for_each_entry(nr, nidlist, nr_link) {
-               nf = nr->nr_netstrfns;
-               lndname = nf->nf_name;
-               if (netnum == -1)
-                       netnum = nr->nr_netnum;
+       first_nidrange = list_entry(nidlist->next, struct nidrange, nr_link);
+
+       netnum = first_nidrange->nr_netnum;
+       nf = first_nidrange->nr_netstrfns;
+       lndname = nf->nf_name;
+
+       rc = nf->nf_min_max(nidlist, &min_addr, &max_addr);
+       if (rc < 0)
+               return rc;
 
-               nf->nf_min_max(nidlist, &min_addr, &max_addr);
-       }
        nf->nf_addr2str(min_addr, min_addr_str, sizeof(min_addr_str));
        nf->nf_addr2str(max_addr, max_addr_str, sizeof(max_addr_str));
 
@@ -1274,37 +1200,53 @@ void cfs_nidrange_find_min_max(struct list_head *nidlist, char *min_nid,
                 netnum);
        snprintf(max_nid, nidstr_length, "%s@%s%d", max_addr_str, lndname,
                 netnum);
+
+       return 0;
 }
 
 /**
  * Determines the min and max NID values for num LNDs
  *
  * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
+ * \param[out] *min_nid if provided, returns string representation of min NID
+ * \param[out] *max_nid if provided, returns string representation of max NID
+ * \retval     -EINVAL unsupported LNET range
+ * \retval     -ERANGE non-contiguous LNET range
  */
-static void cfs_num_min_max(struct list_head *nidlist, __u32 *min_nid,
+static int cfs_num_min_max(struct list_head *nidlist, __u32 *min_nid,
                            __u32 *max_nid)
 {
-       struct nidrange         *nr;
-       struct addrrange        *ar;
-       unsigned int            tmp_min_addr = 0;
-       unsigned int            tmp_max_addr = 0;
-       unsigned int            min_addr = 0;
-       unsigned int            max_addr = 0;
+       struct nidrange *nr;
+       struct addrrange *ar;
+       unsigned int tmp_min_addr = 0;
+       unsigned int tmp_max_addr = 0;
+       unsigned int min_addr = 0;
+       unsigned int max_addr = 0;
+       int nidlist_count = 0;
+       int rc;
 
        list_for_each_entry(nr, nidlist, nr_link) {
+               if (nidlist_count > 0)
+                       return -EINVAL;
+
                list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_num_ar_min_max(ar, &tmp_min_addr,
-                                          &tmp_max_addr);
+                       rc = cfs_num_ar_min_max(ar, &tmp_min_addr,
+                                               &tmp_max_addr);
+                       if (rc < 0)
+                               return rc;
+
                        if (tmp_min_addr < min_addr || min_addr == 0)
                                min_addr = tmp_min_addr;
                        if (tmp_max_addr > max_addr)
                                max_addr = tmp_min_addr;
                }
        }
-       *max_nid = max_addr;
-       *min_nid = min_addr;
+       if (max_nid != NULL)
+               *max_nid = max_addr;
+       if (min_nid != NULL)
+               *min_nid = min_addr;
+
+       return 0;
 }
 
 /**
@@ -1312,32 +1254,52 @@ static void cfs_num_min_max(struct list_head *nidlist, __u32 *min_nid,
  * ip addresses.
  *
  * \param      *nidlist
- * \param      *min_nid
- * \param      *max_nid
+ * \param[out] *min_nid if provided, returns string representation of min NID
+ * \param[out] *max_nid if provided, returns string representation of max NID
+ * \retval     -EINVAL unsupported LNET range
+ * \retval     -ERANGE non-contiguous LNET range
  */
-static void cfs_ip_min_max(struct list_head *nidlist, __u32 *min_nid,
+static int cfs_ip_min_max(struct list_head *nidlist, __u32 *min_nid,
                           __u32 *max_nid)
 {
-       struct nidrange         *nr;
-       struct addrrange        *ar;
-       __u32                   tmp_min_ip_addr = 0;
-       __u32                   tmp_max_ip_addr = 0;
-       __u32                   min_ip_addr = 0;
-       __u32                   max_ip_addr = 0;
+       struct nidrange *nr;
+       struct addrrange *ar;
+       __u32 tmp_min_ip_addr = 0;
+       __u32 tmp_max_ip_addr = 0;
+       __u32 min_ip_addr = 0;
+       __u32 max_ip_addr = 0;
+       int nidlist_count = 0;
+       int rc;
 
        list_for_each_entry(nr, nidlist, nr_link) {
+               if (nidlist_count > 0)
+                       return -EINVAL;
+
+               if (nr->nr_all) {
+                       min_ip_addr = 0;
+                       max_ip_addr = 0xffffffff;
+                       break;
+               }
+
                list_for_each_entry(ar, &nr->nr_addrranges, ar_link) {
-                       cfs_ip_ar_min_max(ar, &tmp_min_ip_addr,
-                                         &tmp_max_ip_addr);
+                       rc = cfs_ip_ar_min_max(ar, &tmp_min_ip_addr,
+                                              &tmp_max_ip_addr);
+                       if (rc < 0)
+                               return rc;
+
                        if (tmp_min_ip_addr < min_ip_addr || min_ip_addr == 0)
                                min_ip_addr = tmp_min_ip_addr;
                        if (tmp_max_ip_addr > max_ip_addr)
                                max_ip_addr = tmp_max_ip_addr;
                }
+
+               nidlist_count++;
        }
 
-       if (min_nid != NULL)
-               *min_nid = min_ip_addr;
        if (max_nid != NULL)
                *max_nid = max_ip_addr;
+       if (min_nid != NULL)
+               *min_nid = min_ip_addr;
+
+       return 0;
 }