Whamcloud - gitweb
git://git.whamcloud.com
/
fs
/
lustre-release.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
LU-14688 mdt: changelog purge deletes plain llog
[fs/lustre-release.git]
/
lustre
/
obdclass
/
local_storage.c
diff --git
a/lustre/obdclass/local_storage.c
b/lustre/obdclass/local_storage.c
index
c15624e
..
2e2a0c4
100644
(file)
--- a/
lustre/obdclass/local_storage.c
+++ b/
lustre/obdclass/local_storage.c
@@
-20,7
+20,7
@@
* GPL HEADER END
*/
/*
* GPL HEADER END
*/
/*
- * Copyright (c) 2012, 201
5
, Intel Corporation.
+ * Copyright (c) 2012, 201
7
, Intel Corporation.
*/
/*
* lustre/obdclass/local_storage.c
*/
/*
* lustre/obdclass/local_storage.c
@@
-35,7
+35,7
@@
#include "local_storage.h"
/* all initialized local storages on this node are linked on this */
#include "local_storage.h"
/* all initialized local storages on this node are linked on this */
-static
struct list_head ls_list_head = LIST_HEAD_INIT
(ls_list_head);
+static
LIST_HEAD
(ls_list_head);
static DEFINE_MUTEX(ls_list_mutex);
static int ls_object_init(const struct lu_env *env, struct lu_object *o,
static DEFINE_MUTEX(ls_list_mutex);
static int ls_object_init(const struct lu_env *env, struct lu_object *o,
@@
-47,7
+47,7
@@
static int ls_object_init(const struct lu_env *env, struct lu_object *o,
ENTRY;
ENTRY;
- ls = container_of
0
(o->lo_dev, struct ls_device, ls_top_dev.dd_lu_dev);
+ ls = container_of(o->lo_dev, struct ls_device, ls_top_dev.dd_lu_dev);
under = &ls->ls_osd->dd_lu_dev;
below = under->ld_ops->ldo_object_alloc(env, o->lo_header, under);
if (below == NULL)
under = &ls->ls_osd->dd_lu_dev;
below = under->ld_ops->ldo_object_alloc(env, o->lo_header, under);
if (below == NULL)
@@
-65,10
+65,11
@@
static void ls_object_free(const struct lu_env *env, struct lu_object *o)
dt_object_fini(&obj->ls_obj);
lu_object_header_fini(h);
dt_object_fini(&obj->ls_obj);
lu_object_header_fini(h);
- OBD_FREE_PTR(obj);
+ OBD_FREE_PRE(obj, sizeof(*obj), "kfreed");
+ kfree_rcu(obj, ls_header.loh_rcu);
}
}
-static struct lu_object_operations ls_lu_obj_ops = {
+static
const
struct lu_object_operations ls_lu_obj_ops = {
.loo_object_init = ls_object_init,
.loo_object_free = ls_object_free,
};
.loo_object_init = ls_object_init,
.loo_object_free = ls_object_free,
};
@@
-100,7
+101,7
@@
static struct lu_object *ls_object_alloc(const struct lu_env *env,
}
}
}
}
-static struct lu_device_operations ls_lu_dev_ops = {
+static
const
struct lu_device_operations ls_lu_dev_ops = {
.ldo_object_alloc = ls_object_alloc
};
.ldo_object_alloc = ls_object_alloc
};
@@
-129,7
+130,7
@@
struct ls_device *ls_find_dev(struct dt_device *dev)
return ls;
}
return ls;
}
-static struct lu_device_type_operations ls_device_type_ops = {
+static
const
struct lu_device_type_operations ls_device_type_ops = {
.ldto_start = NULL,
.ldto_stop = NULL,
};
.ldto_start = NULL,
.ldto_stop = NULL,
};
@@
-371,7
+372,7
@@
static struct dt_object *__local_file_create(const struct lu_env *env,
if (rc)
GOTO(trans_stop, rc);
if (rc)
GOTO(trans_stop, rc);
- dt_write_lock(env, dto,
LOS
_CHILD);
+ dt_write_lock(env, dto,
DT_SRC
_CHILD);
if (dt_object_exists(dto))
GOTO(unlock, rc = 0);
if (dt_object_exists(dto))
GOTO(unlock, rc = 0);
@@
-388,23
+389,23
@@
static struct dt_object *__local_file_create(const struct lu_env *env,
rec->rec_fid = fid;
/* Add "." and ".." for newly created dir */
rc = dt_insert(env, dto, (const struct dt_rec *)rec,
rec->rec_fid = fid;
/* Add "." and ".." for newly created dir */
rc = dt_insert(env, dto, (const struct dt_rec *)rec,
- (const struct dt_key *)".", th
, 1
);
+ (const struct dt_key *)".", th);
if (rc != 0)
GOTO(destroy, rc);
dt_ref_add(env, dto, th);
rec->rec_fid = lu_object_fid(&parent->do_lu);
rc = dt_insert(env, dto, (const struct dt_rec *)rec,
if (rc != 0)
GOTO(destroy, rc);
dt_ref_add(env, dto, th);
rec->rec_fid = lu_object_fid(&parent->do_lu);
rc = dt_insert(env, dto, (const struct dt_rec *)rec,
- (const struct dt_key *)"..", th
, 1
);
+ (const struct dt_key *)"..", th);
if (rc != 0)
GOTO(destroy, rc);
}
rec->rec_fid = fid;
rec->rec_type = dto->do_lu.lo_header->loh_attr;
if (rc != 0)
GOTO(destroy, rc);
}
rec->rec_fid = fid;
rec->rec_type = dto->do_lu.lo_header->loh_attr;
- dt_write_lock(env, parent,
LOS
_PARENT);
+ dt_write_lock(env, parent,
DT_SRC
_PARENT);
rc = dt_insert(env, parent, (const struct dt_rec *)rec,
rc = dt_insert(env, parent, (const struct dt_rec *)rec,
- (const struct dt_key *)name, th
, 1
);
+ (const struct dt_key *)name, th);
if (dti->dti_dof.dof_type == DFT_DIR)
dt_ref_add(env, parent, th);
dt_write_unlock(env, parent);
if (dti->dti_dof.dof_type == DFT_DIR)
dt_ref_add(env, parent, th);
dt_write_unlock(env, parent);
@@
-419,7
+420,7
@@
trans_stop:
dt_trans_stop(env, ls->ls_osd, th);
out:
if (rc) {
dt_trans_stop(env, ls->ls_osd, th);
out:
if (rc) {
-
lu_object_put_nocache(env, &dto->do_lu
);
+
dt_object_put_nocache(env, dto
);
dto = ERR_PTR(rc);
}
RETURN(dto);
dto = ERR_PTR(rc);
}
RETURN(dto);
@@
-502,7
+503,7
@@
struct dt_object *local_file_find_or_create_with_fid(const struct lu_env *env,
ls = ls_device_get(dt);
if (IS_ERR(ls)) {
ls = ls_device_get(dt);
if (IS_ERR(ls)) {
- dto = ERR_
PTR(PTR_ERR(ls)
);
+ dto = ERR_
CAST(ls
);
} else {
/* create the object */
dti->dti_attr.la_valid = LA_MODE;
} else {
/* create the object */
dti->dti_attr.la_valid = LA_MODE;
@@
-515,7
+516,7
@@
struct dt_object *local_file_find_or_create_with_fid(const struct lu_env *env,
* have to open the object in other device stack */
if (!IS_ERR(dto)) {
dti->dti_fid = dto->do_lu.lo_header->loh_fid;
* have to open the object in other device stack */
if (!IS_ERR(dto)) {
dti->dti_fid = dto->do_lu.lo_header->loh_fid;
-
lu_object_put_nocache(env, &dto->do_lu
);
+
dt_object_put_nocache(env, dto
);
dto = dt_locate(env, dt, &dti->dti_fid);
}
ls_device_put(env, ls);
dto = dt_locate(env, dt, &dti->dti_fid);
}
ls_device_put(env, ls);
@@
-597,7
+598,7
@@
local_index_find_or_create_with_fid(const struct lu_env *env,
ls = ls_device_get(dt);
if (IS_ERR(ls)) {
ls = ls_device_get(dt);
if (IS_ERR(ls)) {
- dto = ERR_
PTR(PTR_ERR(ls)
);
+ dto = ERR_
CAST(ls
);
} else {
/* create the object */
dti->dti_attr.la_valid = LA_MODE;
} else {
/* create the object */
dti->dti_attr.la_valid = LA_MODE;
@@
-611,7
+612,7
@@
local_index_find_or_create_with_fid(const struct lu_env *env,
* have to open the object in other device stack */
if (!IS_ERR(dto)) {
dti->dti_fid = dto->do_lu.lo_header->loh_fid;
* have to open the object in other device stack */
if (!IS_ERR(dto)) {
dti->dti_fid = dto->do_lu.lo_header->loh_fid;
-
lu_object_put_nocache(env, &dto->do_lu
);
+
dt_object_put_nocache(env, dto
);
dto = dt_locate(env, dt, &dti->dti_fid);
}
ls_device_put(env, ls);
dto = dt_locate(env, dt, &dti->dti_fid);
}
ls_device_put(env, ls);
@@
-633,6
+634,12
@@
static int local_object_declare_unlink(const struct lu_env *env,
if (rc < 0)
return rc;
if (rc < 0)
return rc;
+ if (S_ISDIR(p->do_lu.lo_header->loh_attr)) {
+ rc = dt_declare_ref_del(env, p, th);
+ if (rc < 0)
+ return rc;
+ }
+
rc = dt_declare_ref_del(env, c, th);
if (rc < 0)
return rc;
rc = dt_declare_ref_del(env, c, th);
if (rc < 0)
return rc;
@@
-672,6
+679,14
@@
int local_object_unlink(const struct lu_env *env, struct dt_device *dt,
if (rc < 0)
GOTO(stop, rc);
if (rc < 0)
GOTO(stop, rc);
+ if (S_ISDIR(dto->do_lu.lo_header->loh_attr)) {
+ dt_write_lock(env, parent, 0);
+ rc = dt_ref_del(env, parent, th);
+ dt_write_unlock(env, parent);
+ if (rc)
+ GOTO(stop, rc);
+ }
+
dt_write_lock(env, dto, 0);
rc = dt_delete(env, parent, (struct dt_key *)name, th);
if (rc < 0)
dt_write_lock(env, dto, 0);
rc = dt_delete(env, parent, (struct dt_key *)name, th);
if (rc < 0)
@@
-684,7
+699,7
@@
int local_object_unlink(const struct lu_env *env, struct dt_device *dt,
rec->rec_fid = &dti->dti_fid;
rec->rec_type = dto->do_lu.lo_header->loh_attr;
rc = dt_insert(env, parent, (const struct dt_rec *)rec,
rec->rec_fid = &dti->dti_fid;
rec->rec_type = dto->do_lu.lo_header->loh_attr;
rc = dt_insert(env, parent, (const struct dt_rec *)rec,
- (const struct dt_key *)name, th
, 1
);
+ (const struct dt_key *)name, th);
GOTO(unlock, rc);
}
GOTO(unlock, rc);
}
@@
-694,7
+709,7
@@
unlock:
stop:
dt_trans_stop(env, dt, th);
out:
stop:
dt_trans_stop(env, dt, th);
out:
-
lu_object_put_nocache(env, &dto->do_lu
);
+
dt_object_put_nocache(env, dto
);
return rc;
}
EXPORT_SYMBOL(local_object_unlink);
return rc;
}
EXPORT_SYMBOL(local_object_unlink);
@@
-719,7
+734,6
@@
void dt_los_put(struct local_oid_storage *los)
/* should never happen, only local_oid_storage_fini should
* drop refcount to zero */
LBUG();
/* should never happen, only local_oid_storage_fini should
* drop refcount to zero */
LBUG();
- return;
}
/* after Lustre 2.3 release there may be old file to store last generated FID
}
/* after Lustre 2.3 release there may be old file to store last generated FID
@@
-747,7
+761,7
@@
static int lastid_compat_check(const struct lu_env *env, struct dt_device *dev,
snprintf(dti->dti_buf, sizeof(dti->dti_buf), "seq-%#llx-lastid",
lastid_seq);
rc = dt_lookup_dir(env, root, dti->dti_buf, &dti->dti_fid);
snprintf(dti->dti_buf, sizeof(dti->dti_buf), "seq-%#llx-lastid",
lastid_seq);
rc = dt_lookup_dir(env, root, dti->dti_buf, &dti->dti_fid);
-
lu_object_put_nocache(env, &root->do_lu
);
+
dt_object_put_nocache(env, root
);
if (rc == -ENOENT) {
/* old llog lastid accessed by FID only */
if (lastid_seq != FID_SEQ_LLOG)
if (rc == -ENOENT) {
/* old llog lastid accessed by FID only */
if (lastid_seq != FID_SEQ_LLOG)
@@
-760,7
+774,7
@@
static int lastid_compat_check(const struct lu_env *env, struct dt_device *dev,
return PTR_ERR(o);
if (!dt_object_exists(o)) {
return PTR_ERR(o);
if (!dt_object_exists(o)) {
-
lu_object_put_nocache(env, &o->do_lu
);
+
dt_object_put_nocache(env, o
);
return 0;
}
CDEBUG(D_INFO, "Found old llog lastid file\n");
return 0;
}
CDEBUG(D_INFO, "Found old llog lastid file\n");
@@
-790,7
+804,7
@@
static int lastid_compat_check(const struct lu_env *env, struct dt_device *dev,
CERROR("%s: failed to read seq-%#llx-lastid: rc = %d\n",
o->do_lu.lo_dev->ld_obd->obd_name, lastid_seq, rc);
}
CERROR("%s: failed to read seq-%#llx-lastid: rc = %d\n",
o->do_lu.lo_dev->ld_obd->obd_name, lastid_seq, rc);
}
-
lu_object_put_nocache(env, &o->do_lu
);
+
dt_object_put_nocache(env, o
);
if (rc == 0)
*first_oid = le32_to_cpu(losd.lso_next_oid);
return rc;
if (rc == 0)
*first_oid = le32_to_cpu(losd.lso_next_oid);
return rc;
@@
-927,7
+941,7
@@
out_los:
OBD_FREE_PTR(*los);
*los = NULL;
if (o != NULL && !IS_ERR(o))
OBD_FREE_PTR(*los);
*los = NULL;
if (o != NULL && !IS_ERR(o))
-
lu_object_put_nocache(env, &o->do_lu
);
+
dt_object_put_nocache(env, o
);
} else {
(*los)->los_seq = fid_seq(first_fid);
(*los)->los_last_oid = le64_to_cpu(lastid);
} else {
(*los)->los_seq = fid_seq(first_fid);
(*los)->los_last_oid = le64_to_cpu(lastid);
@@
-964,7
+978,7
@@
void local_oid_storage_fini(const struct lu_env *env,
}
if (los->los_obj)
}
if (los->los_obj)
-
lu_object_put_nocache(env, &los->los_obj->do_lu
);
+
dt_object_put_nocache(env, los->los_obj
);
list_del(&los->los_list);
OBD_FREE_PTR(los);
mutex_unlock(&ls->ls_los_mutex);
list_del(&los->los_list);
OBD_FREE_PTR(los);
mutex_unlock(&ls->ls_los_mutex);