1 Index: linux-stage/fs/ext4/mballoc.c
2 ===================================================================
3 --- linux-stage.orig/fs/ext4/mballoc.c 2011-03-14 16:34:39.790758415 +0800
4 +++ linux-stage/fs/ext4/mballoc.c 2011-03-14 16:38:36.211681104 +0800
6 INIT_LIST_HEAD(&pa->pa_group_list);
8 pa->pa_type = MB_INODE_PA;
11 mb_debug(1, "new inode pa %p: %llu/%u for %u\n", pa,
12 pa->pa_pstart, pa->pa_len, pa->pa_lstart);
14 INIT_LIST_HEAD(&pa->pa_group_list);
16 pa->pa_type = MB_GROUP_PA;
19 mb_debug(1, "new group pa %p: %llu/%u for %u\n", pa,
20 pa->pa_pstart, pa->pa_len, pa->pa_lstart);
25 + assert_spin_locked(ext4_group_lock_ptr(sb, e4b->bd_group));
26 BUG_ON(pa->pa_deleted == 0);
27 + BUG_ON(pa->pa_inode == NULL);
28 ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, &bit);
29 grp_blk_start = pa->pa_pstart - bit;
30 BUG_ON(group != e4b->bd_group && pa->pa_len != 0);
31 @@ -3752,19 +3756,27 @@
32 mb_free_blocks(pa->pa_inode, e4b, bit, next - bit);
35 - if (free != pa->pa_free) {
36 - printk(KERN_CRIT "pa %p: logic %lu, phys. %lu, len %lu\n",
37 - pa, (unsigned long) pa->pa_lstart,
38 - (unsigned long) pa->pa_pstart,
39 - (unsigned long) pa->pa_len);
41 + /* "free < pa->pa_free" means we maybe double alloc the same blocks,
42 + * otherwise maybe leave some free blocks unavailable, no need to BUG.*/
43 + if ((free > pa->pa_free && !pa->pa_error) || (free < pa->pa_free)) {
44 + ext4_error(sb, "pa free mismatch: [pa %p] "
45 + "[phy %lu] [logic %lu] [len %u] [free %u] "
46 + "[error %u] [inode %lu] [freed %u]", pa,
47 + (unsigned long)pa->pa_pstart,
48 + (unsigned long)pa->pa_lstart,
49 + (unsigned)pa->pa_len, (unsigned)pa->pa_free,
50 + (unsigned)pa->pa_error, pa->pa_inode->i_ino,
52 ext4_grp_locked_error(sb, group,
53 - __func__, "free %u, pa_free %u",
55 + __func__, "free %u, pa_free %u",
58 * pa is already deleted so we use the value obtained
59 * from the bitmap and continue.
62 + BUG_ON(pa->pa_free != free);
63 atomic_add(free, &sbi->s_mb_discarded);
66 @@ -4511,6 +4541,25 @@
67 ac->ac_b_ex.fe_len = 0;
71 + struct ext4_prealloc_space *pa = ac->ac_pa;
73 + /* We can not make sure whether the bitmap has
74 + * been updated or not when fail case. So can
75 + * not revert pa_free back, just mark pa_error*/
78 + "Updating bitmap error: [err %d] "
79 + "[pa %p] [phy %lu] [logic %lu] "
80 + "[len %u] [free %u] [error %u] "
81 + "[inode %lu]", *errp, pa,
82 + (unsigned long)pa->pa_pstart,
83 + (unsigned long)pa->pa_lstart,
84 + (unsigned)pa->pa_len,
85 + (unsigned)pa->pa_free,
86 + (unsigned)pa->pa_error,
87 + pa->pa_inode ? pa->pa_inode->i_ino : 0);
90 block = ext4_grp_offs_to_block(sb, &ac->ac_b_ex);
91 ar->len = ac->ac_b_ex.fe_len;
92 Index: linux-stage/fs/ext4/mballoc.h
93 ===================================================================
94 --- linux-stage.orig/fs/ext4/mballoc.h 2011-03-14 16:32:50.859552482 +0800
95 +++ linux-stage/fs/ext4/mballoc.h 2011-03-14 16:39:20.928429776 +0800
97 #include <linux/version.h>
98 #include <linux/blkdev.h>
99 #include <linux/mutex.h>
100 +#include <linux/genhd.h>
101 #include "ext4_jbd2.h"
105 ext4_grpblk_t pa_free; /* how many blocks are free */
106 unsigned short pa_type; /* pa type. inode or group */
107 spinlock_t *pa_obj_lock;
108 + unsigned short pa_error;
109 struct inode *pa_inode; /* hack, for history only */