Whamcloud - gitweb
LU-10803 ptlrpc: fix req_buffers_max and req_history_max setting 22/31622/3
authorWang Shilong <wshilong@ddn.com>
Mon, 12 Mar 2018 11:51:23 +0000 (19:51 +0800)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 15 Mar 2018 13:53:56 +0000 (13:53 +0000)
commitc11c61a82d668b54a41127a759b2e99cb077ac14
treedd75f60912d604cbff2c6e1388dab37d8d553466
parent108333aa389b9675588a825704f6bce7d7021786
LU-10803 ptlrpc: fix req_buffers_max and req_history_max setting

We hit LU-9372 OOM problems, and after applying
LU-9372 ptlrpc: allow to limit number of service's rqbds
we found two problems:

1)Since 0 is a reserved value for @srv_nrqbds_max which
means unlimited value, procfs write interface should support
this value, otherwise, there is no way to change default behavior
back.

2)the check in ptlrpc_lprocfs_req_history_max_seq_write() was broken
after this patch, the following check will always succeed if @srv_nrqbds_max
is kept as default value 0:

val > svc->srv_nrqbds_max/2

Change-Id: Ida0796fa500fe595e003accc11d20fdad5e60c03
Signed-off-by: Wang Shilong <wshilong@ddn.com>
Reviewed-on: https://review.whamcloud.com/31622
Tested-by: Jenkins
Reviewed-by: Faccini Bruno <bruno.faccini@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/ptlrpc/lproc_ptlrpc.c