Whamcloud - gitweb
LU-5188 osp: Correctly check for invalid setattr record 06/10706/3
authorOleg Drokin <oleg.drokin@intel.com>
Thu, 12 Jun 2014 23:13:25 +0000 (19:13 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Fri, 20 Jun 2014 17:56:16 +0000 (17:56 +0000)
commit79dd530f1352e6b57fcb870a1e0f2c2a05a0648d
treee0f4508e4c4c27e91a2c8548e7303c29e14ec663
parentd70671a610f4e52a4add68d30788133a6ffec638
LU-5188 osp: Correctly check for invalid setattr record

Patch for LU-4345 (commit 80f90fcde73e2faff8b7b0ffc7c19bc52982e027 )
has a correct comment about lsr_valid member being either 0 or
having UID and GID fields set, but the check has a typo causing
it to check for lsr_valid to be both 0 and have the bits set which
is impossible.

The osp_sync_new_setattr_job() should return 0 for invalid record,
so that sync thread can continue processing on other records.

Change-Id: I32e6f261b4707391d6e96f8434aae7bf8f55bf8e
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/10706
Tested-by: Jenkins
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
lustre/osp/osp_sync.c